Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/moscot not #567

Open
wants to merge 257 commits into
base: main
Choose a base branch
from
Open

Feature/moscot not #567

wants to merge 257 commits into from

Conversation

MUCDK
Copy link
Collaborator

@MUCDK MUCDK commented Jun 22, 2023

No description provided.

@jannisborn
Copy link

Very nice effort! Is there any timeline on when this PR will be merged? Or, if you are looking for help, could you describe what is missing for this PR to be merged?

@MUCDK
Copy link
Collaborator Author

MUCDK commented Nov 19, 2023

Very nice effort! Is there any timeline on when this PR will be merged? Or, if you are looking for help, could you describe what is missing for this PR to be merged?

Hi @jannisborn ,

Thanks for your interest in this and your offer for help!
As we are also planning to include more recent and performant neural OT estimators, we currently work on their implementations on the OTT-JAX side, and this way get a better idea of how to structure the different neural OT models into one module. As we would like to build moscot upon OTT-JAX as much as possible, we would like to wait until we have a better idea about the implementation on the OTT-JAX side.

Regarding the time line: We will work very intensely on the OTT-JAX implementation next week, and hence - hopefully - the week after, we can focus on the moscot implementation.

If you would like to contribute, or test the implementation and give usability feedback, we would highly appreciate this!

@hbenedek
Copy link

Hi @MUCDK!

I am working with @jannisborn and saw that you started to incorporate this PR to ott-jax (and GENOT and more). I would be more than happy to help out with testing/ giving feedback or contributing!

@MUCDK
Copy link
Collaborator Author

MUCDK commented Nov 27, 2023

Hi @hbenedek ,
Great to hear you're interested in collaborating! Indeed, I would highly appreciate your help.
I think/hope we'll be done with the implementation on the ott-jax side by the end of this week. Still, please feel free to play around with the current implementation and provide feedback. This way, you'll get to know the API, and we can implement the models (i.e. OT-FM, GENOT, and eventually ICNN-OT (all in their conditional format, too) into moscot next week. Therefore, it'd be great if you are familiar with these models, as this will make the workflow easier!

Let's chat about details of the ott-jax -> moscot implementation in the beginning of next week!

@hbenedek
Copy link

Thanks @MUCDK! I will try to familiarize myself with the API and the models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants