ASOC: SOF: Intel: hda-loader: do not wait for HDaudio IOC #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujfalusi
approved these changes
Aug 7, 2024
plbossart
approved these changes
Aug 7, 2024
This was referenced Aug 7, 2024
kv2019i
force-pushed
the
202408-no-fw-load-ioc-wait
branch
from
1fd8976
to
81065be
Compare
|
V2:
|
ranj063
approved these changes
Aug 7, 2024
ujfalusi
reviewed
Aug 8, 2024
Commit 9ee3f0d ("ASOC: SOF: Intel: hda-loader: only wait for HDaudio IOC for IPC4 devices") removed DMA wait for IPC3 case. Proceed and remove the wait for IPC4 devices as well. There is no dependency to IPC version in the load logic and checking the firmware status is a sufficient check in case of errors. The removed code also had a bug in that -ETIMEDOUT is returned without stopping the DMA transfer. Link: thesofproject#5135 Fixes: 9ee3f0d ("ASOC: SOF: Intel: hda-loader: only wait for HDaudio IOC for IPC4 devices") Suggested-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202408-no-fw-load-ioc-wait
branch
from
81065be
to
2e40b1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9ee3f0d (" ASOC: SOF: Intel: hda-loader: only wait for HDaudio IOC for IPC4 devices") removed DMA wait for IPC3 case. Proceed and remove the wait for IPC4 devices as well.
There is no dependency to IPC version in the load logic and checking the firmware status is a sufficient check in case of errors.
The removed code also had a bug in that -ETIMEDOUT is returned without stopping the DMA transfer.
Link: #5135
Suggested-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com