PR5136 + ASOC: SOF: Intel: hda-stream: report DMA position if FW load fail #5141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 9ee3f0d (" ASOC: SOF: Intel: hda-loader: only wait for HDaudio IOC for IPC4 devices") removed DMA wait for IPC3 case. Proceed and remove the wait for IPC4 devices as well. There is no dependency to IPC version in the load logic and checking the firmware status is a sufficient check in case of errors. The removed code also had a bug in that -ETIMEDOUT is returned without stopping the DMA transfer. Link: thesofproject#5135 Suggested-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
When a single-shot DMA is complete, hda_dsp_stream_get_position() will point to hstream->bufsize. Current code zeros out the returned position in this case as ALSA core does not expect to get such values in its pointer callback. While valid in the ALSA case, this is no helpful when debugging other DMA usages, e.g. firmware loading. Allow valid value of hstream->bufsize to be returned as a position. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To help debugging FW load failures, print out the last position of the DMA used to load the firmware image. This allows to see whether DMA transfer has started and whether it completed. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
|
Example how we could add debugging tools back after the IOC check is removed. |
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5136