Tools: Topology2: Add IIR, FIR, DRC to HDA analog playback #8934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
commented
Mar 12, 2024
|
Topology before and after pictures: |
This patch replaces pipeline mixout-gain-dai-copier-playback with mixout-gain-efx-dai-copier-playback. The purpose is to allow enhance of audio playback quality with equalizers (IIR and FIR) and dynamic range control (DRC). The components are programmed by default to passthrough for minimal overhead. They can be activated via sof-ctl or UCM with ALSA controls. - Post Mixer Analog Playback IIR Eq bytes - Post Mixer Analog Playback FIR Eq bytes - Post Mixer Analog Playback DRC bytes - Post Mixer Analog Playback DRC switch The recommendation is to keep headphone playback flat and enable processing only when HDA output is in speaker mode. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
tplg2_hda_add_drc_eq_spk
branch
from
d0f3aa1
to
87dd3c7
Compare
jsarha
reviewed
Mar 13, 2024
Yes you are right. I was thinking to keep efx as development topology, with more features added soon, and copy them eventually to default topology names once the new features are considered stabilized. |
jsarha
approved these changes
Mar 13, 2024
kv2019i
approved these changes
Mar 14, 2024
|
Known pause-resume seen on https://sof-ci.01.org/sofpr/PR8934/build3325/devicetest/index.html . In https://sof-ci.01.org/sofpr/PR8934/build3326/devicetest/index.html otherwise good, but multicore tests hit #8942 |
fredoh9
added a commit
to fredoh9/sof
that referenced
this pull request
Mar 18, 2024
This is reverting SOF PR8934. thesofproject#8934 This reverts commit 727ad82.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces pipeline mixout-gain-dai-copier-playback with mixout-gain-efx-dai-copier-playback. The purpose is to allow enhance of audio playback quality with equalizers (IIR and FIR) and dynamic range control (DRC).
The components are programmed by default to passthrough for minimal overhead. They can be activated via sof-ctl or UCM with ALSA controls.
The recommendation is to keep headphone playback flat and enable processing only when HDA output is in speaker mode.