Implement Python 3.12 compatible loader. Fixes #130. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thp
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks! Some comments inline plus these:
- Add a changelog entry in
Version UNRELEASEDsection indocs/index.rstfor this - In
.github/workflows/build.yaml, changepython@3.8topython@3.12 - As some of these loader features were only introduced in a Python version >= 3.3, we should bump the minimum version in
README.mdto Python 3.8, as everything before that is end-of-life (+ add to the changelog)
apollo13
commented
Mar 12, 2024
src/qrc_importer.py
Outdated
| def create_module(self, spec): | ||
| return None | ||
|
|
||
| def exec_module(self, module): |
There was a problem hiding this comment.
I don't know Python's import System well enough. Maybe https://docs.python.org/3.11/library/importlib.html#importlib.abc.SourceLoader could be used instead of having to manually exec stuff?
There was a problem hiding this comment.
I have managed to rewrite it back to the SourceLoader, let me know what you think.
|
@thp Is there anything you miss here? |
|
@thp you plan to tag a release including this fix? fixes yubikey-manager-qt 😊 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.