Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the smart contract API README files #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pdyraga
Copy link
Member

@pdyraga pdyraga commented Jun 29, 2023

Refs keep-network/tbtc-v2#553

Mentioned where the code for the given module is located and that the documentation is generated based on the NatSpec docs in the code.

Made the list of smart contracts for the given module a real list.

Mentioned where the code for the given module is located and that the
documentation is generated based on the NatSpec docs in the code.

Made the list of smart contracts for the given module a real list.
@michalinacienciala
Copy link
Contributor

@pdyraga, fyi, there are conflicts after be52966 got in. I'm clarifying with @erdogan on Discord if we should use this modified file structure...

The smart contract API documentation is generated based on the NatSpec format
documentation in the smart contract source code.

The Random Bitcoin contracts API docs are available [here](random-beacon-api/generated-docs/index.md).
Copy link
Contributor

@michalinacienciala michalinacienciala Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After switching from contracts documentation in single file to multiple files, I missed that we should update also this link:

Suggested change
The Random Bitcoin contracts API docs are available [here](random-beacon-api/generated-docs/index.md).
The Random Bitcoin contracts API docs are available [here](random-beacon-api/README.md).

We could update this in this PR. Similar change needed for other project's API's READMEs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants