Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redemption improvements #583

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Redemption improvements #583

merged 3 commits into from
Jul 27, 2023

Conversation

r-czajkowski
Copy link
Collaborator

This PR adds some improvements to Redemptions in T dapp.

Main changes:

  • fix typos
  • update the copy- adjust the redemption time saying it's around 3-5 hours
  • make Elapsed Time on the Redemption details page as dynamic countdown

Currently 3 hours is quite optimistic and it often takes around 5 hours
(experienced that during UATs several times). Here we update a copy
saying that a redemption takes `3-5 hours`.
`transacion` -> `transaction`
The Elapsed Time should be a dynamic countdown. Here we update the
elapsed time every one minute.
@github-actions
Copy link

@r-czajkowski r-czajkowski modified the milestones: v1.10.0, v1.9.1 Jul 27, 2023
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@michalsmiarowski michalsmiarowski merged commit fdae36e into main Jul 27, 2023
5 checks passed
@michalsmiarowski michalsmiarowski deleted the redemption-improvements branch July 27, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants