Support for 3-way validation split interface #701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #697
This PR adds support for the new interface to validation sets in rsample via
initial_validation_split()
andvalidation_set()
.As laid out in #697 (comment), this
last_fit()
to work with objects coming frominitial_validation_split()
use_validation_set
tolast_fit()
andfit_best()
use_validation_set
so that we keep using the validation set for objects coming from the old interface but do not use it for objects from the new interfaceTo make that possible, rsample adds another attribute to validation
rset
objects coming from the new interfacevalidation_set()
in tidymodels/rsample#437For reference, we will deprecate the old interface: tidymodels/rsample#350