Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC 1.1.2 #707

Closed
wants to merge 7 commits into from
Closed

RC 1.1.2 #707

wants to merge 7 commits into from

Conversation

EmilHvitfeldt
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt commented Jul 29, 2023

This PR a a hot fix release. It includes 1.1.1 plus the content of the following two PRs

It is not Meant to be merged!

Once the release from this PR is completed, then #708 should be merged.

@topepo
Copy link
Member

topepo commented Aug 1, 2023

Have you run revdeps?

@EmilHvitfeldt
Copy link
Member Author

Nope, forgot, doing it now!

@EmilHvitfeldt
Copy link
Member Author

EmilHvitfeldt commented Aug 2, 2023

The following revdepcheck is run with:

Remotes:
    tidymodels/rsample
── CHECK ──────────────────────────────────────────────── 27 packages ──
✔ bonsai 0.2.1                           ── E: 0     | W: 0     | N: 0    
✔ autostats 0.4.0                        ── E: 0     | W: 0     | N: 0    
✔ agua 0.1.3                             ── E: 0     | W: 0     | N: 0    
✔ finetune 1.1.0                         ── E: 0     | W: 0     | N: 0    
✔ finnts 0.2.4                           ── E: 0     | W: 0     | N: 0    
✔ healthyR.ai 0.0.13                     ── E: 0     | W: 0     | N: 0    
✔ HTRX 1.2.2                             ── E: 0     | W: 0     | N: 1    
✖ healthyR.ts 0.2.9                      ── E: 0  +1 | W: 0     | N: 1    
✖ modeltime 1.2.7                        ── E: 0  +1 | W: 0     | N: 1    
✔ modeltime.ensemble 1.0.3               ── E: 0     | W: 0     | N: 1    
✔ nestedmodels 1.0.4                     ── E: 0     | W: 0     | N: 0    
✔ modeltime.resample 0.2.3               ── E: 0     | W: 0     | N: 1    
✔ probably 1.0.2                         ── E: 0     | W: 0     | N: 0    
✔ RISCA 1.0.4                            ── E: 0     | W: 0     | N: 0    
✔ sknifedatar 0.1.2                      ── E: 1     | W: 0     | N: 0    
✔ shinymodels 0.1.0                      ── E: 0     | W: 0     | N: 1    
✔ stacks 1.0.2                           ── E: 0     | W: 0     | N: 0    
✔ tabnet 0.4.0                           ── E: 0     | W: 0     | N: 0    
✔ survivalSL 0.91                        ── E: 0     | W: 0     | N: 0    
✔ text 0.9.99.2                          ── E: 0     | W: 0     | N: 1    
✔ tidymodels 1.1.0                       ── E: 0     | W: 0     | N: 0    
✔ tidyclust 0.1.2                        ── E: 0     | W: 0     | N: 0    
✔ tidyposterior 1.0.0                    ── E: 0     | W: 0     | N: 0    
I workboots 0.2.0                        ── E: 1     | W: 0     | N: 0    
✔ timetk 2.8.3                           ── E: 0     | W: 0     | N: 1    
✔ usemodels 0.2.0                        ── E: 0     | W: 0     | N: 0    
✔ workflowsets 1.0.1                     ── E: 0     | W: 0     | N: 0    
OK: 25                                                                
BROKEN: 2
Total time: 13 min

The {healthyR.ts} is is related to {rsample} is fixed in spsanderson/healthyR.ts#439, but not on CRAN.

The {modeltime} is a false positive. Was able to verify outside of revdepcheck.

@hfrick hfrick mentioned this pull request Aug 21, 2023
@hfrick
Copy link
Member

hfrick commented Aug 22, 2023

FYI there is a new version of healthyR.ts on CRAN with the fix for rsample

@topepo topepo closed this Aug 24, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants