Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale name first #5583

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Scale name first #5583

merged 6 commits into from
Dec 14, 2023

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5535.

Briefly, it explicitly sets the first argument of many scales to the name argument. Thereby, we're circumventing the issue that ... would funnel the first argument to the deprecated scale_name argument.

@teunbrand teunbrand added this to the ggplot2 3.5.0 milestone Dec 14, 2023
thomasp85
thomasp85 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand
Copy link
Collaborator Author

Thanks for the review Thomas!

@teunbrand teunbrand merged commit 0f9fb64 into tidyverse:main Dec 14, 2023
12 checks passed
@teunbrand teunbrand deleted the scale_name_first branch December 14, 2023 20:57
@teunbrand teunbrand mentioned this pull request Jan 8, 2024
Merged
@teunbrand teunbrand mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.5.0
Development

Successfully merging this pull request may close these issues.

First argument to scales is not longer the name of the scale
2 participants
@teunbrand @thomasp85