Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm building a new package to find and automatically fix lints in R code:
flint
.I'm using real-life, large packages to check its performance and
ggplot2
is one of them. Since I already test on this, there's no additional cost for me in proposing those changes.FYI, those changes were all generated by
flint::fix_dir("R")
.There are many changes but most of them are trivial:
any(is.na())
byanyNA()
=
assignment by<-
(since both are used across the codebase, I guess<-
should be the default).1
->0.1
)and a few other things.
flint
is quite new and linter rules are necessarily a bit opinionated, so some of those changes might not be to your taste, but I'd be happy to have some feedback on this.