Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ink and paper settings for built-in themes #6059

Closed
wants to merge 52 commits into from
Closed

Ink and paper settings for built-in themes #6059

wants to merge 52 commits into from

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix an issue discussed during conf.

Briefly, treading in the footsteps of #5833, we give ink and paper argument to built-in themes.

The ink sets all foreground elements, which by default is 'black'. Likewise, paper sets all background elements, which by default is 'white'.

Some examples of non-default options:

Changing the foreground

devtools::load_all("~/packages/ggplot2")
#> ℹ Loading ggplot2
p <- ggplot(mpg, aes(displ, hwy)) +
  geom_point()

p + theme_bw(ink = "dodgerblue")

Changing the background

p + theme_gray(paper = "orchid")

Cheap dark-mode option

p + theme_light(ink = "white", paper = "black")

Created on 2024-08-26 with reprex v2.1.1

teunbrand and others added 30 commits April 5, 2024 15:47
@teunbrand
draft new geom element in themes
08300bd
@teunbrand
plumbing for providing theme to Geom$use_defaults()
8c24ab9
@teunbrand
make from_theme() as eval helper
60af7a3
@teunbrand
Evaluate default aesthetics from theme
f551c8b
@teunbrand
allow user-specified from_theme()
ced8c15
@teunbrand
plumbing for guides to observe theme
659fd09
@teunbrand
reoxygenate
2cec833
@teunbrand
Add text settings
5637501
@teunbrand
Add text settings
2d28202
@teunbrand
accept minor fontsize difference (11.04pt -> 11.00pt)
5f2ebf9
@teunbrand
Merge branch 'theme_geom_defaults' of https://github.com/teunbrand/gg…
87af93e 
…plot2 into theme_geom_defaults
@teunbrand
temporarily disable sf_grob() default lookups
f503409
@teunbrand
temporary shim for colour mixing
f08fcb6
@teunbrand
Get all colour/fill/linewidth from theme
b5ffd32
@teunbrand
test theme has geom element
93a9258
@teunbrand
adapt tests
5e9136f
@teunbrand
resolve merge conflict
962004e 
Merge branch 'main' into theme_geom_defaults

# Conflicts:
#	R/geom-.R
#	R/geom-sf.R
@teunbrand
geom_sf() has themed defaults
6185e82
@teunbrand
we don't expect complete themes anymore
df571c0
@teunbrand
shim auto-replaces itself when exported from scales
92d2bbb
@teunbrand
theme defaults for point size/shape
124dd5f
@teunbrand
boxplot point shape/size default from GeomBoxplot$default_aes
0ff6078
@teunbrand
accept larger points in large theme snapshots
2dd3f37
@teunbrand
document
377a82c
@teunbrand
Point to theme setting in update_geom_defaults()
e584978
@teunbrand
document from_theme()
1143a9f
@teunbrand
add news bullet
afca781
@teunbrand @thomasp85
Update R/geom-pointrange.R
f0b4279 
Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com>
@thomasp85
Run revdepcheck
b0251f3
@teunbrand
resolve merge conflict
0a99ec7 
Merge branch 'main' into theme_geom_defaults

# Conflicts:
#	R/theme-elements.R
#	R/theme.R
#	man/theme.Rd
teunbrand and others added 22 commits May 22, 2024 09:39
@teunbrand
implement @yutannihilation's suggestion
d41758f
@teunbrand
resolve merge conflict
ddfba94 
Merge branch 'main' into theme_geom_defaults

# Conflicts:
#	R/geom-.R
#	R/geom-sf.R
#	R/guide-legend.R
#	R/layer.R
@thomasp85
run revdepcheck
99a3b58
@teunbrand
Merge branch 'main' into theme_geom_defaults
6741230
@teunbrand
resolve merge conflict
7762341 
Merge branch 'main' into theme_geom_defaults

# Conflicts:
#	R/geom-sf.R
#	R/theme-defaults.R
#	revdep/README.md
#	revdep/cran.md
#	revdep/failures.md
#	revdep/problems.md
@thomasp85
revdepcheck once again
dbea0a6
@teunbrand
protect against missing theme
789ec08
@teunbrand
skip empty sf layers
0d682f1
@teunbrand
getter for geom defaults
e6afd5c
@teunbrand
add test
6a08f2d
@teunbrand
Merge branch 'main' into theme_geom_defaults
f87e548
@teunbrand
tmp
f1fae8e
@teunbrand
add linetype to element_geom()
b73f1d2
@teunbrand
geom_path() treats integer 1L as solid (in addition to numeric 1)
c511902
@teunbrand
get linetype from theme
7ffab68
@teunbrand
Merge branch 'theme_geom_defaults' of https://github.com/teunbrand/gg…
43037b5 
…plot2 into theme_geom_defaults
@teunbrand
Merge branch 'main' into theme_geom_defaults
e728d19
@teunbrand
Merge branch 'main' into theme_geom_defaults
e718db1
@teunbrand
abstract away theme colours
e17010f
@teunbrand
document
1d3d87b
@teunbrand
add news bullet
f7d8a76
@teunbrand
resolve merge conflict
fedd319 
Merge branch 'main' into theme_ink

# Conflicts:
#	R/geom-defaults.R
#	R/theme-defaults.R
#	R/utilities.R
@teunbrand teunbrand mentioned this pull request Aug 27, 2024
Merged
@teunbrand
Copy link
Collaborator Author

Closing this in favour of #6063

@teunbrand teunbrand closed this Aug 27, 2024
teunbrand added a commit that referenced this pull request Sep 13, 2024
@teunbrand
Ink and paper settings for built-in themes (re: #6059) (#6063)
6d48584 
* abstract away theme colours

* add snapshot test

* add news bullet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teunbrand @thomasp85