Ink and paper settings for built-in themes (re: #6059) #6063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
changed the title
thomasp85
approved these changes
Sep 13, 2024
| @@ -154,14 +156,14 @@ theme_grey <- function(base_size = 11, base_family = "", | |||
| axis.line = element_blank(), | |||
| axis.line.x = NULL, | |||
| axis.line.y = NULL, | |||
| axis.text = element_text(size = rel(0.8), colour = "grey30"), | |||
| axis.text = element_text(size = rel(0.8), colour = col_mix(ink, paper, 0.305)), | |||
There was a problem hiding this comment.
I assume there is a numerical reason why you need the third digit in some but not all of these mix operations?
There was a problem hiding this comment.
Yeah this is just to land on the right hex code to preserve visual tests. I have no scruples to just take the prettier number here (like 0.3).
There was a problem hiding this comment.
I thought so - let's just keep it as is to not mess with other packages visual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements #6059 due to a gnarly git history that I couldn't manage to resolve.
The reasoning for this PR remains unchanged, but I'll post the examples again so that you can see that these are the same:
Created on 2024-08-27 with reprex v2.1.1