Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mapping_based_calibrator): typo in the lidar-lidar calibrator #211

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Nov 11, 2024

Description

As pointed in #209, the checkKeyframeLost was wrongly computed due to a typo that ignored one of the conditions. This PR addresses that issue.

Related links

Issue: #209

Tests performed

None

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 requested a review from vividf November 11, 2024 06:03
@knzo25 knzo25 self-assigned this Nov 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (bab5400) to head (2334c0e).
Report is 25 commits behind head on tier4/universe.

Files with missing lines Patch % Lines
...apping_based_calibrator/src/calibration_mapper.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           tier4/universe    #211      +/-   ##
=================================================
- Coverage            0.93%   0.00%   -0.94%     
=================================================
  Files                 270      28     -242     
  Lines               21339    2653   -18686     
  Branches              383     223     -160     
=================================================
- Hits                  200       0     -200     
+ Misses              20982    2653   -18329     
+ Partials              157       0     -157     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vividf vividf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knzo25 knzo25 merged commit 923c748 into tier4:tier4/universe Nov 15, 2024
6 checks passed
@knzo25 knzo25 deleted the fix/lidar-lidar-typo branch November 15, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants