Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make serve generic over the listener and IO types #2941

Merged
merged 5 commits into from
Nov 30, 2024
Merged

Make serve generic over the listener and IO types #2941

merged 5 commits into from
Nov 30, 2024

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Sep 27, 2024

Supersedes #2479.

@jplatte jplatte mentioned this pull request Sep 27, 2024
Closed
@jplatte jplatte changed the base branch from main to jplatte/msrv175 September 28, 2024 16:38
@jplatte jplatte force-pushed the jplatte/generic-serve branch 2 times, most recently from 53c870c to 72871dc Compare September 28, 2024 17:16
@jplatte jplatte added this to the 0.8 milestone Sep 28, 2024
Base automatically changed from jplatte/msrv175 to main September 28, 2024 21:21
@jplatte jplatte force-pushed the jplatte/generic-serve branch from 72871dc to 26a37a4 Compare September 28, 2024 21:30
@jplatte jplatte requested a review from mladedav September 28, 2024 21:30
daheige
daheige approved these changes Sep 29, 2024
View reviewed changes
Copy link

@daheige daheige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mladedav
mladedav reviewed Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@mladedav mladedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

The underlying theme of the comments seems to be what do we want this to eventually look like and whether to move some functionality in serve into the Listener instances so I guess that's the main thing I'd want your opinions on.

axum/src/serve.rs Outdated Show resolved Hide resolved
axum/src/serve.rs Outdated Show resolved Hide resolved
axum/src/serve.rs Outdated Show resolved Hide resolved
@milen-denev milen-denev mentioned this pull request Oct 14, 2024
Closed
@jplatte jplatte force-pushed the jplatte/generic-serve branch from 26a37a4 to e8644d8 Compare November 30, 2024 15:21
@jplatte
Copy link
Member Author

jplatte commented Nov 30, 2024

@mladedav I think I've addressed all of your concern with the three new commits I've added. Let me know what you think!

@jplatte jplatte force-pushed the jplatte/generic-serve branch from a5f7c1d to c6df5f4 Compare November 30, 2024 15:32
mladedav
mladedav approved these changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@mladedav mladedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great. Thanks for finishing it.

@jplatte jplatte merged commit 84c3960 into main Nov 30, 2024
18 checks passed
@jplatte jplatte deleted the jplatte/generic-serve branch November 30, 2024 22:47
@ttys3 ttys3 mentioned this pull request Dec 1, 2024
Closed
1 task
@banditopazzo banditopazzo mentioned this pull request Dec 11, 2024
Draft
@Turbo87 Turbo87 mentioned this pull request Dec 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mladedav mladedav mladedav approved these changes

@daheige daheige daheige approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@jplatte @daheige @mladedav