Support Omnipose. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class Adapting variable names Adapting comments Changing file name
…cellpose cyto2 and not omnipose cyto2 model
Adding example video
- CellposeSettings and OmniposeSettings inherit from an abstract class that does everything except the model. - Models for omnipose and cellpose are 2 separate enums, but that implement a common interface. - OmniposeUtils merged with CellposeUtils. - CellposeDetector becomes an omnipose detector when provided with an OmniposeSettings. No need for a second OmniposeDetector class. - The detector factory and config panel classes for omnipose inherit from their cellpose counterparts. Fix #7
Adding docu in the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the work of @marieanselmet .
Instead of having two separate repos the omnipose support from Marie is merged here in this repo. This allowed rewriting parts of code to avoid duplication.
There are two detectors, one for cellpose one for omnipose. In theory, since we call python directly, we could have made just one. But this way is clearer for the user and allow managing separately specifics models.