Deprecate CBOR as a serialization format

.github/workflows/ci.yml

@@ -104,7 +104,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        serde_format: [bincode, cbor, cbor4ii, postcard]
+        serde_format: [bincode, postcard]
         toolchain: [stable, nightly]
         self_ty_in_mod_name: [false, true]
 

README.md

@@ -407,9 +407,9 @@ The `test-fuzz` package currently supports the following features:
 
 - `serde_bincode` - [Bincode] (default)
 
-- `serde_cbor` - [Serde CBOR]
+- `serde_cbor` - [Serde CBOR] (deprecated)
 
-- `serde_cbor4ii` - [CBOR 0x(4+4)9 0x49]
+- `serde_cbor4ii` - [CBOR 0x(4+4)9 0x49] (deprecated)
 
 - `serde_postcard` - [Postcard]
 

cargo-test-fuzz/tests/fuzz_generic.rs

@@ -1,4 +1,4 @@
-use internal::{dirs::corpus_directory_from_target, serde_format};
+use internal::dirs::corpus_directory_from_target;
 use predicates::prelude::*;
 use std::{fs::remove_dir_all, sync::Mutex};
 use testing::{examples, retry, CommandExt};
@@ -10,14 +10,7 @@ const MAX_TOTAL_TIME: &str = "60";
 fn fuzz_foo_qwerty() {
     // smoelius: When `bincode` is enabled, `cargo-afl` fails because "the program crashed with one
     // of the test cases provided."
-    fuzz(
-        "test_foo_qwerty",
-        if serde_format::serializes_variant_names() {
-            1
-        } else {
-            2
-        },
-    );
+    fuzz("test_foo_qwerty", 2);
 }
 
 #[cfg_attr(dylint_lib = "general", allow(non_thread_safe_call_in_test))]

internal/src/serde_format.rs

@@ -36,21 +36,6 @@ pub fn as_feature() -> &'static str {
     formats.pop().expect("No serde format selected")
 }
 
-#[must_use]
-pub const fn serializes_variant_names() -> bool {
-    #[cfg(any(serde_default, feature = "__serde_bincode"))]
-    return false;
-
-    #[cfg(feature = "__serde_cbor")]
-    return true;
-
-    #[cfg(feature = "__serde_cbor4ii")]
-    return true;
-
-    #[cfg(feature = "__serde_postcard")]
-    return false;
-}
-
 pub fn serialize<T: Serialize>(args: &T) -> Vec<u8> {
     #[cfg(any(serde_default, feature = "__serde_bincode"))]
     return {

test-fuzz/tests/serde_format.rs

@@ -22,10 +22,8 @@ fn serde_format() {
         let mut file = File::open(path).unwrap();
         let mut buf = Vec::new();
         file.read_to_end(&mut buf).unwrap();
-        // smoelius: CBOR stores the variant name.
-        assert_eq!(
-            cfg!(any(feature = "serde_cbor", feature = "serde_cbor4ii")),
-            buf.iter().any(u8::is_ascii_uppercase)
-        );
+        // smoelius: CBOR stores the variant name. Hence, this test will fail if CBOR is used as the
+        // serialization format.
+        assert!(!buf.iter().any(u8::is_ascii_uppercase));
     }
 }