Add nodePort to helm service.yaml #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Isan-Rivkin
requested changes
Sep 29, 2024
| @@ -9,6 +9,9 @@ spec: | |||
| ports: | |||
| - port: {{ .Values.service.port }} | |||
| targetPort: http | |||
| {{- if .Values.service.nodePort }} | |||
There was a problem hiding this comment.
please keep the if statement at the same ident level as the field itself
| @@ -9,6 +9,9 @@ spec: | |||
| ports: | |||
| - port: {{ .Values.service.port }} | |||
| targetPort: http | |||
| {{- if .Values.service.nodePort }} | |||
There was a problem hiding this comment.
please assert that .Values.service.type == "NodePort" to avoid issues for users configuring this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding nodePort to the service.yaml enables a static external port to access the LakeFS GUI.
This is good for smaller deployments and testing.