Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nodePort to helm service.yaml #282

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add nodePort to helm service.yaml #282

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e11ed97
Add nodePort to helm service.yaml
gauthier-labs Sep 25, 2024
fd49c81
Update service.yaml to check eq .Values.service.type "NodePort"
gauthier-labs Oct 31, 2024
6c068b8
Update Chart.yaml version
gauthier-labs Oct 31, 2024
aae68c5
Merge branch 'master' into patch-1
gauthier-labs Oct 31, 2024
bd4e26c
Update Chart.yaml
gauthier-labs Oct 31, 2024
cdea80c
Merge branch 'master' into patch-1
gauthier-labs Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/lakefs/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ spec:
ports:
- port: {{ .Values.service.port }}
targetPort: http
{{- if .Values.service.nodePort }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep the if statement at the same ident level as the field itself

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated indentation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please assert that .Values.service.type == "NodePort" to avoid issues for users configuring this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added check for .Values.service.type

nodePort: {{ .Values.service.nodePort }}
{{- end }}
protocol: TCP
name: http
selector:
Expand Down
Loading