Add a unit test #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will pull with approval from any reviewer, not all -- if you want to approve but wait, please let me know and I will wait! |
arielshaqed
added
enhancement
Based on GitHub's default.
arielshaqed
force-pushed
the
feature/add-unit-test
branch
from
97de875
to
3f4d370
Compare
arielshaqed
force-pushed
the
feature/add-unit-test
branch
from
e307e63
to
db2139e
Compare
Spark doesn't like a newer JRE.
arielshaqed
force-pushed
the
feature/add-unit-test
branch
from
db2139e
to
a5d463c
Compare
CI is currently so cheap, it's better to run it always.
arielshaqed
force-pushed
the
feature/add-unit-test
branch
from
8e7efa0
to
c95f193
Compare
It fails reporting, and actions suggested in https://github.com/marketplace/actions/sbt-dependency-submission#unexpected-status-403 don't work and are also not particularly safe.
arielshaqed
force-pushed
the
feature/add-unit-test
branch
2 times, most recently
from
cbc4323
to
675617d
Compare
johnnyaug
approved these changes
Aug 21, 2023
| @@ -50,6 +50,7 @@ object SchemaDiff { | |||
| } | |||
| val Seq(tablePrefix, fromSchema, toSchema, tableSuffix) = e.map(computeString) | |||
| val sqlString = sql(tablePrefix, fromSchema, toSchema, tableSuffix) | |||
| print(s"[DEBUG] $sqlString") | |||
There was a problem hiding this comment.
Yikes, this no longer belongs here!
Removed...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tests only a simple change between a table on 2 different schemas.