Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate hard-coded 'Enable labeling' string #4128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Translate hard-coded 'Enable labeling' string #4128

wants to merge 1 commit into from

Conversation

bieleluk
Copy link
Contributor

Fixes #3813

prusnak
prusnak requested changes Aug 26, 2024
View reviewed changes
core/src/apps/misc/cipher_key_value.py Outdated Show resolved Hide resolved
@matejcik
Copy link
Contributor

please add a changelog entry

prusnak
prusnak reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added few nit-picks, otherwise ACK:

  1. let's order the assignments the same way they are called below in confirm_action (that is title, description, verb)
  2. let's use A = B if C else D idiom for title

core/src/apps/misc/cipher_key_value.py Outdated Show resolved Hide resolved
core/src/apps/misc/cipher_key_value.py Outdated Show resolved Hide resolved
@bieleluk bieleluk marked this pull request as ready for review August 27, 2024 13:53
@matejcik matejcik added the translations Put this label on a PR to run tests in all languages label Aug 27, 2024
@bieleluk
Copy link
Contributor Author

bieleluk commented Nov 1, 2024

Had to rebase the branch because the CI was blocked due to conflicts in the translation files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

Assignees

@bieleluk bieleluk

Labels
translations Put this label on a PR to run tests in all languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a workaround for "Enable labelling" to be translatable
3 participants
@bieleluk @matejcik @prusnak