refactor: Migrates Python tests to pytest #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavm-nvidia
force-pushed
the
improve-tests
branch
from
13a4f01 to
8cced02
Compare
pranavm-nvidia
changed the title
pranavm-nvidia
force-pushed
the
improve-tests
branch
from
d8aabf4 to
18b1b46
Compare
Migrates test_api.py to pytest and removes `unittest`. Changes setup functions to fixtures and replaces `unittest` assertion methods with regular Python `assert`s. Also lowers the timeout for the server to make the tests run a bit faster.
Replaces all `unittest` APIs with equivalent `pytest` ones. This change also updates the tests to use `tempfile` instead of manually creating and removing files and directories.
pranavm-nvidia
force-pushed
the
improve-tests
branch
3 times, most recently
from
c815df7 to
f911d7d
Compare
pranavm-nvidia
force-pushed
the
improve-tests
branch
from
f911d7d to
16097dd
Compare
rmccorm4
approved these changes
Dec 13, 2024
rmccorm4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates test_api.py to pytest
Migrates test_api.py to pytest and removes
unittest. Changes setup functionsto fixtures and replaces
unittestassertion methods with regular Pythonasserts.Also lowers the timeout for the server to make the tests run a bit faster.
Updates test_binding.py to use pytest
Replaces all
unittestAPIs with equivalentpytestones. This changealso updates the tests to use
tempfileinstead of manually creating andremoving files and directories.
Parametrizes tests instead of running loops