Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crate-ci/typos from 1.20.0 to 1.20.1 #123

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 2, 2024

Bumps crate-ci/typos from 1.20.0 to 1.20.1.

Release notes

Sourced from crate-ci/typos's releases.

v1.20.1

[1.20.1] - 2024-04-01

Fixes

  • Don't correct of (OpenGraph's namespace), a regression from 1.20.0

Fixes

  • Don't correct eof, a regression from 1.20.0
Changelog

Sourced from crate-ci/typos's changelog.

[1.20.1] - 2024-04-01

Fixes

  • Don't correct og (OpenGraph's namespace), a regression from 1.20.0

Fixes

  • Don't correct eof, a regression from 1.20.0
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.20.0 to 1.20.1.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.20.0...v1.20.1)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 2, 2024
@JoshuaLampert
Copy link
Member

I just triggered dependabot manually to double-check if codecov now works on dependabot PRs.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.80%. Comparing base (65424b4) to head (6f1762c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   17.80%   17.80%           
=======================================
  Files           3        3           
  Lines        1427     1427           
=======================================
  Hits          254      254           
  Misses       1173     1173           
Flag Coverage Δ
unittests 17.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert
Copy link
Member

So codecov works now. Unfortunately, the documentation still doesn't build successfully on dependabot PRs. I was hoping that adding DOCUMENTER_KEY to the dependabot secrets would help, but it still does not work. The key, however, is recognized, but it says that it "is not correctly set up": https://github.com/trixi-framework/P4est.jl/actions/runs/8523570341/job/23348894725#step:7:43. I created the key in the usual way as explained in the docs of Documenter.jl.

@JoshuaLampert
Copy link
Member

JoshuaLampert commented Apr 2, 2024

In the corresponding Trixi.jl PR the docs build and deploy successfully (https://github.com/trixi-framework/Trixi.jl/actions/runs/8528195201/job/23361270967?pr=1895), but not here. Do you know why, @ranocha?

@ranocha
Copy link
Member

ranocha commented Apr 3, 2024

It may be because I re-opened the PR?

@ranocha ranocha closed this Apr 3, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 3, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@ranocha ranocha reopened this Apr 3, 2024
@ranocha
Copy link
Member

ranocha commented Apr 3, 2024

Let's see whether that has an influence here as well

@JoshuaLampert
Copy link
Member

It indeed worked.

@JoshuaLampert JoshuaLampert merged commit be124a7 into main Apr 3, 2024
28 of 29 checks passed
@JoshuaLampert JoshuaLampert deleted the dependabot/github_actions/crate-ci/typos-1.20.1 branch April 3, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants