NAS-132742 / 25.04 / fix key collision in zpool.status

[yocalebo]

Someone named one of their zpools disks..... A strange zpool name but it caused a key collision in zpool.status. Place all zpools underneath a top-level pools key to prevent this scenario.

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132742

[themylogin]

Why are pool names and static keys mixed in one dictionary? Can we have it like

{
    "disks": {...},
    "pools": {...},
}

?

[yocalebo]

Why are pool names and static keys mixed in one dictionary? Can we have it like

{
    "disks": {...},
    "pools": {...},
}

?

Yeah, that's a better idea and actually has less risk of regression but also introduces more lines changed (since tests have to be updated). I've made those changes.

[themylogin]

Thank you!

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.