Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kgo: ignore aborted txns if using READ_UNCOMMITTED #758

Merged
merged 2 commits into from
Jun 8, 2024
Merged

kgo: ignore aborted txns if using READ_UNCOMMITTED #758

merged 2 commits into from
Jun 8, 2024

Commits on Jun 8, 2024

  1. remove govulncheck GHA 

    This is a library; it is on upstream users to bump deps. Having
vulnchecks here is ... semi valuable, but currently noisy with an
unfixable dep.
    @twmb
    twmb committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    c64c3d3 View commit details
    Browse the repository at this point in the history

  2. kgo: ignore aborted txns if using READ_UNCOMMITTED 

    Kafka does not return AbortedTransactions in the fetch response if the
client is using read uncommitted, so kgo works perfectly against Kafka.
Redpanda DOES return AbortedTransactions (today, although this is being
changed) even if the client is using READ_UNCOMMITTED, which causes
records to be skipped. Redpanda is changing, but we can address this in
kgo as well.
    @twmb
    twmb committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    9e32bf9 View commit details
    Browse the repository at this point in the history