kgo: ignore aborted txns if using READ_UNCOMMITTED #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a library; it is on upstream users to bump deps. Having vulnchecks here is ... semi valuable, but currently noisy with an unfixable dep.
Kafka does not return AbortedTransactions in the fetch response if the client is using read uncommitted, so kgo works perfectly against Kafka. Redpanda DOES return AbortedTransactions (today, although this is being changed) even if the client is using READ_UNCOMMITTED, which causes records to be skipped. Redpanda is changing, but we can address this in kgo as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka does not return AbortedTransactions in the fetch response if the
client is using read uncommitted, so kgo works perfectly against Kafka.
Redpanda DOES return AbortedTransactions (today, although this is being
changed) even if the client is using READ_UNCOMMITTED, which causes
records to be skipped. Redpanda is changing, but we can address this in
kgo as well.