make record compression into default features #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves support for each record compression type into its own cargo feature.
This will improve build times for projects that:
By default all of these new features are enabled since a regular client or broker would want to support all of them.
If a compression feature is not enabled it is up to the client or broker implementation to communicate that to the other side at the protocol level to avoid hitting the
"support for {c:?} is not enabled as a cargo feature"
error.One downside is this has increased our CI runtime from 2 mins to 17 mins.
But I think this is tolerable and worth it.
In the future, if we find adding more features blows up the CI time to rediculous levels we can adjust
cargo hack
to avoidmessages_enums
in the main combinatorial run as that is the largest contributor to build time.