Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: Add overlay for ESP32S3 #2

Merged
merged 1 commit into from
Sep 18, 2024
Merged

samples: Add overlay for ESP32S3 #2

merged 1 commit into from
Sep 18, 2024

Conversation

viniciusmiguel
Copy link
Contributor

ESP32S3 tested

uLipe
uLipe requested changes Sep 17, 2024
View reviewed changes
Copy link
Owner

@uLipe uLipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, please just add to the commit message what was done for esp32, for example:

samples: add board support

then in the commit body:

For esp32s3 DevKtim, via dts overlay.

This would help to keep some consistency on the commit history.

@viniciusmiguel
samples: Add board support
41e9445 
For esp32s3 DevKitC, via dts overlay.

Signed-off-by: Vinicius Miguel <vmiguel1@gmail.com>
@viniciusmiguel
Copy link
Contributor Author

LGTM so far, please just add to the commit message what was done for esp32, for example:

samples: add board support

then in the commit body:

For esp32s3 DevKtim, via dts overlay.

This would help to keep some consistency on the commit history.

Done

@uLipe uLipe self-assigned this Sep 18, 2024
@uLipe uLipe merged commit 7f95e44 into uLipe:main Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uLipe uLipe uLipe approved these changes

Assignees

@uLipe uLipe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viniciusmiguel @uLipe