Curvedpath fix #101
Merged
Curvedpath fix #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nithos
reviewed
Aug 22, 2023
| @@ -26,15 +26,18 @@ export interface CurvedPathEdgeData { | |||
| control: number | number[]; | |||
| sourceColor?: GraferInputColor, | |||
| targetColor?: GraferInputColor, | |||
| pickingColor?: number | [number, number, number, number]; | |||
There was a problem hiding this comment.
I presume vectors are used quite a bit, so in that case it may be useful to extract this into a type at least the array. i.e type vec4 = { r: number, g: number .... }
There was a problem hiding this comment.
vectors are used quite a bit, this vec4/uvec4 is present in a few places in the code, i think if we want to consolidate the types it might be better to do it in a seperate PR so we dont have 4 additional unrelated files in this PR. what do you think?
There was a problem hiding this comment.
i'm fine with that, this was just a thought but yes if we have this throughout the code base we should have a clean up PR
Nithos
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.