Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

599 - Action to add Edges to the Architecture Graph to solve Divergences #629

Merged

Conversation

m4xxed
Copy link
Collaborator

@m4xxed m4xxed commented Aug 9, 2023

This feature intends to solve Issue #599, which is to give the user the ability to select an edge that is divergent after mapping the implementation nodes to the architecture nodes, and to find and create an edge within the architecture itself, that solves this reflexion divergence.

The main implementation is within the files AcceptDivergenceAction.cs and AcceptDivergenceNetAction.cs.

Creating this divergence-solving edge should also be propagated to clients via a NetAction.

Feature tasks:

  • create an edge in architecture graph to solve a selected divergence
  • undo
  • redo
  • network: edge creation
  • network: undo
  • network: redo

Other tasks:

  • master merge
  • testing
  • network testing

m4xxed and others added 30 commits May 25, 2023 23:25
Co-authored-by: Falko <10247603+falko17@users.noreply.github.com>
m4xxed and others added 18 commits August 13, 2023 10:55
…cene.

This namespace contains (typically static) classes that manipulate
game objects in the scene representing nodes or edges. They will
be shared among our Actions and their corresponding NetActions.
The intention here is to avoid redundancy among Actions and
NetActions as both need to change the scene the same way.
…cture' of github.com:uni-bremen-agst/SEE into 599-reflexion-sync-edges-from-implementation-to-architecture
Copy link
Collaborator

@koschke koschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is fine now.

I made additional changes:

  • Extracted a class for the code shared among the Action and its NetAction.
  • Created a new namespace for all scene manipulators.
  • Removed obsolete classes.

@koschke koschke enabled auto-merge August 17, 2023 08:22
@koschke koschke merged commit cd37420 into master Aug 17, 2023
8 checks passed
@koschke koschke deleted the 599-reflexion-sync-edges-from-implementation-to-architecture branch August 17, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bachelorproject Something applicable to the bachelor project, e.g. its report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants