-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
599 - Action to add Edges to the Architecture Graph to solve Divergences #629
Merged
koschke
merged 73 commits into
master
from
599-reflexion-sync-edges-from-implementation-to-architecture
Aug 17, 2023
Merged
599 - Action to add Edges to the Architecture Graph to solve Divergences #629
koschke
merged 73 commits into
master
from
599-reflexion-sync-edges-from-implementation-to-architecture
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-to-architecture
falko17
requested changes
Aug 11, 2023
Co-authored-by: Falko <10247603+falko17@users.noreply.github.com>
falko17
approved these changes
Aug 11, 2023
falko17
reviewed
Aug 11, 2023
…edges-from-implementation-to-architecture
Added a FIXME marker.
…cene. This namespace contains (typically static) classes that manipulate game objects in the scene representing nodes or edges. They will be shared among our Actions and their corresponding NetActions. The intention here is to avoid redundancy among Actions and NetActions as both need to change the scene the same way.
…cture' of github.com:uni-bremen-agst/SEE into 599-reflexion-sync-edges-from-implementation-to-architecture
… AcceptDivergenceNetAction.
koschke
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All is fine now.
I made additional changes:
- Extracted a class for the code shared among the Action and its NetAction.
- Created a new namespace for all scene manipulators.
- Removed obsolete classes.
koschke
deleted the
599-reflexion-sync-edges-from-implementation-to-architecture
branch
August 17, 2023 10:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature intends to solve Issue #599, which is to give the user the ability to select an edge that is divergent after mapping the implementation nodes to the architecture nodes, and to find and create an edge within the architecture itself, that solves this reflexion divergence.
The main implementation is within the files AcceptDivergenceAction.cs and AcceptDivergenceNetAction.cs.
Creating this divergence-solving edge should also be propagated to clients via a
NetAction
.Feature tasks:
Other tasks: