Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

599 - Action to add Edges to the Architecture Graph to solve Divergences #629

Merged
merged 73 commits into from
Aug 17, 2023
Merged

599 - Action to add Edges to the Architecture Graph to solve Divergences #629

merged 73 commits into from
Aug 17, 2023

Commits on May 25, 2023

  1. add Action and NetAction to accept Divergences into Architecture

    @m4xxed
    m4xxed committed May 25, 2023
    Configuration menu
    Copy the full SHA
    ad2048e View commit details
    Browse the repository at this point in the history

  2. add ActionStateType for AcceptDivergenceAction

    @m4xxed
    m4xxed committed May 25, 2023
    Configuration menu
    Copy the full SHA
    19bad11 View commit details
    Browse the repository at this point in the history

  3. add correct implementation next to current workaround

    @m4xxed
    m4xxed committed May 25, 2023
    Configuration menu
    Copy the full SHA
    a2eb3e9 View commit details
    Browse the repository at this point in the history

  4. add convenience method to check for divergence

    @m4xxed
    m4xxed committed May 25, 2023
    Configuration menu
    Copy the full SHA
    2ffd5a9 View commit details
    Browse the repository at this point in the history

  5. switch from "dirty hack" to actual solution - works

    @m4xxed
    m4xxed committed May 25, 2023
    Configuration menu
    Copy the full SHA
    f556b92 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. fix grammar of documentation

    @m4xxed
    m4xxed committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    55566a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. remove unused import #599

    @m4xxed
    m4xxed committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    28c9e41 View commit details
    Browse the repository at this point in the history

  2. remove unneccesary workaround #599

    @m4xxed
    m4xxed committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    a50db64 View commit details
    Browse the repository at this point in the history

  3. disable networkaction temporarily #599

    @m4xxed
    m4xxed committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    64c5691 View commit details
    Browse the repository at this point in the history

  4. update documentation #599

    @m4xxed
    m4xxed committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    0d36940 View commit details
    Browse the repository at this point in the history

  5. add functionality to create edges #599

    @m4xxed
    m4xxed committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    169b7b6 View commit details
    Browse the repository at this point in the history

  6. fix imports #599

    @m4xxed
    m4xxed committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    c562db2 View commit details
    Browse the repository at this point in the history

  7. start adding basic redo functionality #599

    @m4xxed
    m4xxed committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d128490 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Merge branch 'master' into 599-reflexion-sync-edges-from-implementati… 

    …on-to-architecture
    @m4xxed
    m4xxed committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    7de3d45 View commit details
    Browse the repository at this point in the history

  2. something went wrong while merging - reverted to master state #599

    @m4xxed
    m4xxed committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    e63c849 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. use GameEdgeAdder to add Edge to Game

    @m4xxed
    m4xxed committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    1c153b8 View commit details
    Browse the repository at this point in the history

  2. add DrawEdge method that accepts an existing Edge as parameter

    @m4xxed
    m4xxed committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    9f56502 View commit details
    Browse the repository at this point in the history

  3. add DrawEdge because it is required in GraphRenderer

    @m4xxed
    m4xxed committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    dd9155c View commit details
    Browse the repository at this point in the history

  4. overload DrawEdge to accept an existing DataModel.Edge as parameter

    @m4xxed
    m4xxed committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    6180133 View commit details
    Browse the repository at this point in the history

  5. fixed formatting

    @m4xxed
    m4xxed committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    4c7a097 View commit details
    Browse the repository at this point in the history

  6. add new Draw() method to GameEdgeAdder

    @m4xxed
    m4xxed committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    1850bdf View commit details
    Browse the repository at this point in the history

  7. temporary placeholder until we figure out a better way

    @m4xxed
    m4xxed committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    fed7e6f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Automatic changes by Unity

    @falko17
    falko17 committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    ca8e634 View commit details
    Browse the repository at this point in the history

  2. Use new new in EdgeRenderer

    @falko17
    falko17 committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    3941a48 View commit details
    Browse the repository at this point in the history

  3. Pass correct source object to Renderer.DrawEdge

    @falko17
    falko17 committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    2826904 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. add audio and a networkaction to edge creation

    @m4xxed
    m4xxed committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    9a60c00 View commit details
    Browse the repository at this point in the history

  2. reorder Class to fit order convention and add undo / redo

    @m4xxed
    m4xxed committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    72c8a3f View commit details
    Browse the repository at this point in the history

  3. add NetAction to accept divergences

    @m4xxed
    m4xxed committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    25ae3a3 View commit details
    Browse the repository at this point in the history

  4. completed undo- and redo functionality

    @m4xxed
    m4xxed committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    07c4283 View commit details
    Browse the repository at this point in the history

  5. complete overhaul of the docstrings and inline documentation

    @m4xxed
    m4xxed committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    4373f92 View commit details
    Browse the repository at this point in the history

  6. fixed order of actions - AcceptDivergence now before MetricBoard

    @m4xxed
    m4xxed committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b7b8701 View commit details
    Browse the repository at this point in the history

  7. rename method to a less blame-y name and adjust documentation

    @m4xxed
    m4xxed committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    2160453 View commit details
    Browse the repository at this point in the history

  8. fix and / or add documentation

    @m4xxed
    m4xxed committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    4b7a95a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. passing GUID to clients to have matching GUID

    @m4xxed
    m4xxed committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    bf8fbba View commit details
    Browse the repository at this point in the history

  2. corrected, appended and adjusted documentation

    @m4xxed
    m4xxed committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    5d1d558 View commit details
    Browse the repository at this point in the history

  3. removed unused function (AddEdge(Edge) works better)

    @m4xxed
    m4xxed committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    5066546 View commit details
    Browse the repository at this point in the history

  4. check whether both GameObject and Node can be found

    @m4xxed
    m4xxed committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b352259 View commit details
    Browse the repository at this point in the history

  5. improve documentation

    @m4xxed
    m4xxed committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    36ac009 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into 599-reflexion-sync-edges-from-implementati… 

    …on-to-architecture
    @m4xxed
    m4xxed committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    756e437 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. remove extraneous newlines and dead code 

    autoformatting for those extraneous newlines would be super neat here, right? 😁
    @m4xxed
    m4xxed authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ce1fd9f View commit details
    Browse the repository at this point in the history

  2. add assertion, that the new edge is actually in architecture 

    for consistency, I'd commit anything!

Co-authored-by: Falko <10247603+falko17@users.noreply.github.com>
    @m4xxed @falko17
    m4xxed and falko17 authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    362f28e View commit details
    Browse the repository at this point in the history

  3. ensure edge is in archticture to avoid exceptions 

    Co-authored-by: Falko <10247603+falko17@users.noreply.github.com>
    @m4xxed @falko17
    m4xxed and falko17 authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f8579f0 View commit details
    Browse the repository at this point in the history

  4. renamed variable to be more descriptive

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    abc12dc View commit details
    Browse the repository at this point in the history

  5. remove old comments and add missing documentation

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7513994 View commit details
    Browse the repository at this point in the history

  6. remove comment that should've been removed before commit

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    eaa02b2 View commit details
    Browse the repository at this point in the history

  7. add "missing" braces

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7e3cb0a View commit details
    Browse the repository at this point in the history

  8. refactor code to make it look smoother

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    aa14af6 View commit details
    Browse the repository at this point in the history

  9. remove unneccessary lookups

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    8d57202 View commit details
    Browse the repository at this point in the history

  10. update documentation 

    Co-authored-by: Falko <10247603+falko17@users.noreply.github.com>
    @m4xxed @falko17
    m4xxed and falko17 authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ba361ff View commit details
    Browse the repository at this point in the history

  11. simplify documentation

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1ffa907 View commit details
    Browse the repository at this point in the history

  12. update documentation

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    375f2fe View commit details
    Browse the repository at this point in the history

  13. remove variable and nesting complexity

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    6e099fa View commit details
    Browse the repository at this point in the history

  14. remove redundancy in documentation 

    Co-authored-by: Falko <10247603+falko17@users.noreply.github.com>
    @m4xxed @falko17
    m4xxed and falko17 authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    00a5e64 View commit details
    Browse the repository at this point in the history

  15. fixed checking in wrong graph

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f2ac554 View commit details
    Browse the repository at this point in the history

  16. fixed check for wrong graph

    @m4xxed
    m4xxed committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ad2429c View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. fixed documentation

    @m4xxed
    m4xxed committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    0f93c7f View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Merge remote-tracking branch 'origin/master' into 599-reflexion-sync-… 

    …edges-from-implementation-to-architecture
    @koschke
    koschke committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a94a752 View commit details
    Browse the repository at this point in the history

  2. #599 Fixed copy&paste error in documentation.

    @koschke
    koschke committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    08bd443 View commit details
    Browse the repository at this point in the history

  3. #599 GlobalHistoryEntry can be readonly.

    @koschke
    koschke committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    abac963 View commit details
    Browse the repository at this point in the history

  4. #599 Replaced magic strings by edge-type declarations in Edge.

    @koschke
    koschke committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    9f2f358 View commit details
    Browse the repository at this point in the history

  5. #599 Simplified new operator.

    @koschke
    koschke committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1e09e7c View commit details
    Browse the repository at this point in the history

  6. #599 Architecture does not need to be capitalized.

    @koschke
    koschke committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c417919 View commit details
    Browse the repository at this point in the history

  7. #599 Removed obsolete implementation hint.

    @koschke
    koschke committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    10fa2f3 View commit details
    Browse the repository at this point in the history

  8. #599 Added missing import.

    @koschke
    koschke committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    8e60295 View commit details
    Browse the repository at this point in the history

  9. #599 We can use Find. Fixed misleading error message. 

    Added a FIXME marker.
    @koschke
    koschke committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    735a67b View commit details
    Browse the repository at this point in the history

  10. fix documentation - change check to catch propagated edges too

    @m4xxed
    m4xxed committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d27b8d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. #599 Removed obsolete class that was once created only for video reco… 

    …rding.
    @koschke
    koschke committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    63b8b36 View commit details
    Browse the repository at this point in the history

  2. #599 Created namespace for classes manipulating game objects in the s… 

    …cene.

This namespace contains (typically static) classes that manipulate
game objects in the scene representing nodes or edges. They will
be shared among our Actions and their corresponding NetActions.
The intention here is to avoid redundancy among Actions and
NetActions as both need to change the scene the same way.
    @koschke
    koschke committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9df862b View commit details
    Browse the repository at this point in the history

  3. Merge branch '599-reflexion-sync-edges-from-implementation-to-archite… 

    …cture' of github.com:uni-bremen-agst/SEE into 599-reflexion-sync-edges-from-implementation-to-architecture
    @koschke
    koschke committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    7aa9390 View commit details
    Browse the repository at this point in the history

  4. #599 Removed obsolete class.

    @koschke
    koschke committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    832b437 View commit details
    Browse the repository at this point in the history

  5. #599 Removed obsolete class.

    @koschke
    koschke committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    2a69e52 View commit details
    Browse the repository at this point in the history

  6. #599 Use simplified new operator.

    @koschke
    koschke committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    a8e1b6b View commit details
    Browse the repository at this point in the history

  7. #599 Extracted class for code shared among AcceptDivergenceAction and… 

    … AcceptDivergenceNetAction.
    @koschke
    koschke committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    eba4451 View commit details
    Browse the repository at this point in the history