Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Myanmar Extended-C #416

Merged
merged 17 commits into from
Oct 17, 2023
Merged

Myanmar Extended-C #416

merged 17 commits into from
Oct 17, 2023

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Mar 6, 2023

For unicode-org/properties#57, according to L2/22-046, per 171-C20:

[171-C20] Consensus: Accept 20 Myanmar numerals (U+116D0U+116E3) for Eastern Pwo Karen and Pa’O in a new Myanmar Extended-C block, with range U+116D0..U+116FF for a future version of the standard. (Reference L2/22-046)

The proposal did not supply information for LineBreak.txt, so I inferred that from the GC (GC=Nd is almost always LB=NU).

116D0..116E3   ; NU # Nd    [20] MYANMAR PAO DIGIT ZERO..MYANMAR EASTERN PWO KAREN DIGIT NINE

Generated files updated as follows.

mvn compile exec:java '-Dexec.mainClass="org.unicode.text.UCD.Main"'  '-Dexec.args="build MakeUnicodeFiles"' -am -pl unicodetools  "-DCLDR_DIR=..\cldr\"  "-DUNICODETOOLS_GEN_DIR=Generated"  "-DUNICODETOOLS_REPO_DIR=."
cp .\Generated\UCD\15.1.0\* .\unicodetools\data\ucd\dev -recurse -force
rm unicodetools\data\ucd\dev\zzz-unchanged-*
rm unicodetools\data\ucd\dev\*\zzz-unchanged-*
rm .\unicodetools\data\ucd\dev\extra\*
rm .\unicodetools\data\ucd\dev\cldr\*

@eggrobin
Copy link
Member Author

eggrobin commented Mar 6, 2023

(The CI failure is from UCA validation checking.)

@markusicu
Copy link
Member

Nice start!

I am surprised that there is no CI failure about having to run GenerateEnums.java.

The second commit looks like it mixes inputs and generated outputs. I suspect that for rebasing and conflict resolution it will be useful to separate those.

@eggrobin
Copy link
Member Author

eggrobin commented Mar 6, 2023

The second commit looks like it mixes inputs and generated outputs. I suspect that for rebasing and conflict resolution it will be useful to separate those.

I don’t think it does? At least I have tried to keep that separation.

@markusicu
Copy link
Member

The second commit looks like it mixes inputs and generated outputs.

I don’t think it does?

It seems like PropertyValueAliases.txt should be an input (while maybe also getting reformatted). I see that you first changed ShortBlockNames.txt, I guess that PVA.txt gets it from there. Ideally, I think the tools should just parse PVA.txt and we should be able to delete ShortBlockNames.txt. One of many things that should get cleaned up...

I see now that ScriptExtensions.txt is just reformatted/reordered. (I wonder if the tool is flaky for that order.)

@eggrobin eggrobin mentioned this pull request Mar 6, 2023
@eggrobin
Copy link
Member Author

eggrobin commented Oct 2, 2023

Checked consistency with Ken’s UnicodeData-16.0.0d6.txt and LineBreak-16.0.0d2.txt.

@eggrobin
Copy link
Member Author

eggrobin commented Oct 2, 2023

CI does not pass because of collation.

@eggrobin eggrobin marked this pull request as ready for review October 4, 2023 21:15
unicodetools/data/ucd/dev/Blocks.txt Outdated Show resolved Hide resolved
unicodetools/data/ucd/dev/extracted/DerivedName.txt Outdated Show resolved Hide resolved
unicodetools/data/ucd/dev/ScriptExtensions.txt Outdated Show resolved Hide resolved
@markusicu markusicu self-assigned this Oct 16, 2023
eggrobin and others added 2 commits October 17, 2023 14:25
Co-authored-by: Markus Scherer <markus.icu@gmail.com>
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Once you merge the new main into another PR I can look at that.

@eggrobin eggrobin merged commit d669b0b into unicode-org:main Oct 17, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants