-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Myanmar Extended-C #416
Myanmar Extended-C #416
Conversation
(The CI failure is from UCA validation checking.) |
Nice start! I am surprised that there is no CI failure about having to run GenerateEnums.java. The second commit looks like it mixes inputs and generated outputs. I suspect that for rebasing and conflict resolution it will be useful to separate those. |
I don’t think it does? At least I have tried to keep that separation. |
It seems like PropertyValueAliases.txt should be an input (while maybe also getting reformatted). I see that you first changed ShortBlockNames.txt, I guess that PVA.txt gets it from there. Ideally, I think the tools should just parse PVA.txt and we should be able to delete ShortBlockNames.txt. One of many things that should get cleaned up... I see now that ScriptExtensions.txt is just reformatted/reordered. (I wonder if the tool is flaky for that order.) |
Checked consistency with Ken’s UnicodeData-16.0.0d6.txt and LineBreak-16.0.0d2.txt. |
CI does not pass because of collation. |
2daa2bb
to
57c0d31
Compare
Co-authored-by: Markus Scherer <markus.icu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Once you merge the new main into another PR I can look at that.
For unicode-org/properties#57, according to L2/22-046, per 171-C20:
The proposal did not supply information for LineBreak.txt, so I inferred that from the GC (GC=Nd is almost always LB=NU).
Generated files updated as follows.