Add macOS and Linux support, fix Windows build Regression #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Points to the correct repository now instead of the upstream repository
Added proper support for macOS, Linux, ARM64, and ARM32 based systems. Rewrote handling artifacts from unzipping, to moving artifacts to correct directories based on what platforms are downloaded and what is currently running on. Added documentation to helper functions.
New platforms are able to link and build. Tested on macOS.
Enabling exceptions for the compiler causes the project to build without issues, as the compiler would not like having no exception support similar to how macOS operates.
garrettsummerfi3ld
changed the title
Might need more work but at least it doesn't error
On Windows builds, there was an issue with dependencies not copying and therefore not linking when building native modules, this is now fixed.
Removed duplicated builds and renamed builds of CANBridge.
The stopHeartbeats function was removed in a previous commit, which caused MSVC builds to break. This commit re-adds the function to fix the build. The function will need to be reimplemented with the current codebase, as of right now this does nothing.
garrettsummerfi3ld
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor of the
download-CanBridge.mjsscript.Points to the correct repository now instead of the upstream repository.
Added proper support for macOS, Linux, ARM64, and ARM32 based systems.
Rewrote handling artifacts from unzipping, to moving artifacts to correct directories based on what platforms are downloaded and what is currently running on.
Added documentation to helper functions.
Closes #2 and #3