Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Repo Update - TokenizingTextBox #59

Draft
wants to merge 203 commits into
base: uno
Choose a base branch
from

Conversation

michael-hawker
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

Pull in updates from main repo like TokenizingTextBox
Update build numbers to 6.0.0-build.{height}

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

michael-hawker added a commit to unoplatform/Uno.Graph-Controls that referenced this pull request Sep 19, 2019
Needs artifacts from unoplatform/Uno.WindowsCommunityToolkit#59
Don't forget to add ClientID :)
@michael-hawker
Copy link
Collaborator Author

@carldebilly @jeromelaban stack below look familiar? Hitting a run-time crash right after UI initialization (i.e. I'm seeing controls in Android emulator before app stops).

I've uploaded my local test branch here, just needs the artifacts from this build and a ClientID to repro. Run Android head, it should build and deploy. Right after controls appear, app goes down these errors in the debug log below.

For comparison, my integrated POC test branch from last week with an earlier iteration of control changes worked fine, that's here.

09-19 10:04:38.401 I/zygote  ( 6662): Rejecting re-init on previously-failed class java.lang.Class<http://android.support.v4.view.ViewCompat$OnUnhandledKeyEventListenerWrapper>: java.lang.NoClassDefFoundError: Failed resolution of: Landroid/view/View$OnUnhandledKeyEventListener;
09-19 10:04:38.401 I/zygote  ( 6662):   at void http://android.support.v4.view.ViewCompat.setOnApplyWindowInsetsListener(android.view.View, http://android.support.v4.view.OnApplyWindowInsetsListener) (http://ViewCompat.java:2203)
09-19 10:04:38.401 I/zygote  ( 6662):   at android.view.ViewGroup http://android.support.v7.app.AppCompatDelegateImpl.createSubDecor() (http://AppCompatDelegateImpl.java:637)
09-19 10:04:38.401 I/zygote  ( 6662):   at void http://android.support.v7.app.AppCompatDelegateImpl.ensureSubDecor() (http://AppCompatDelegateImpl.java:518)
09-19 10:04:38.401 I/zygote  ( 6662):   at void http://android.support.v7.app.AppCompatDelegateImpl.setContentView(android.view.View) (http://AppCompatDelegateImpl.java:457)
09-19 10:04:38.401 I/zygote  ( 6662):   at void http://android.support.v7.app.AppCompatActivity.setContentView(android.view.View) (http://AppCompatActivity.java:145)
09-19 10:04:38.401 I/zygote  ( 6662):   at void md5bf4da100b2dbb022d895d9bb2c38dfa6.NativeApplication_ActivityCallbacks.n_onActivityStarted(http://android.app.Activity) (NativeApplication_ActivityCallbacks.java:-2)
09-19 10:04:38.401 I/zygote  ( 6662):   at void md5bf4da100b2dbb022d895d9bb2c38dfa6.NativeApplication_ActivityCallbacks.onActivityStarted(http://android.app.Activity) (NativeApplication_ActivityCallbacks.java:83)
09-19 10:04:38.401 I/zygote  ( 6662):   at void http://android.app.Application.dispatchActivityStarted(https://t.co/bPt5oAB8yK.Activity) (http://Application.java:207)
09-19 10:04:38.401 I/zygote  ( 6662):   at void http://android.app.Activity.onStart() (http://Activity.java:1245)
09-19 10:04:38.402 I/zygote  ( 6662):   at void http://android.support.v4.app.FragmentActivity.onStart() (http://FragmentActivity.java:614)
09-19 10:04:38.402 I/zygote  ( 6662):   at void http://android.support.v7.app.AppCompatActivity.onStart() (http://AppCompatActivity.java:178)
09-19 10:04:38.402 I/zygote  ( 6662):   at void md567cff875f28d20379ac19e960a3af0b6.BaseActivity.n_onStart() (http://BaseActivity.java:-2)
09-19 10:04:38.402 I/zygote  ( 6662):   at void md567cff875f28d20379ac19e960a3af0b6.BaseActivity.onStart() (http://BaseActivity.java:609)
09-19 10:04:38.402 I/zygote  ( 6662):   at void http://android.app.Instrumentation.callActivityOnStart(https://t.co/bPt5oAB8yK.Activity) (http://Instrumentation.java:1334)
09-19 10:04:38.402 I/zygote  ( 6662):   at void http://android.app.Activity.performStart() (http://Activity.java:7029)
09-19 10:04:38.402 I/zygote  ( 6662):   at http://android.app.Activity http://android.app.ActivityThread.performLaunchActivity(http://android.app.ActivityThread$ActivityClientRecord, android.content.Intent) (http://ActivityThread.java:2741)
09-19 10:04:38.402 I/zygote  ( 6662):   at void http://android.app.ActivityThread.handleLaunchActivity(http://android.app.ActivityThread$ActivityClientRecord, android.content.Intent, java.lang.String) (http://ActivityThread.java:2856)
09-19 10:04:38.402 I/zygote  ( 6662):   at void http://android.app.ActivityThread.-wrap11(http://android.app.ActivityThread, http://android.app.ActivityThread$ActivityClientRecord, android.content.Intent, java.lang.String) (http://ActivityThread.java:-1)
09-19 10:04:38.402 I/zygote  ( 6662):   at void http://android.app.ActivityThread$H.handleMessage(android.os.Message) (http://ActivityThread.java:1589)
09-19 10:04:38.402 I/zygote  ( 6662):   at void android.os.Handler.dispatchMessage(android.os.Message) (http://Handler.java:106)
09-19 10:04:38.402 I/zygote  ( 6662):   at void android.os.Looper.loop() (http://Looper.java:164)
09-19 10:04:38.402 I/zygote  ( 6662):   at void http://android.app.ActivityThread.main(java.lang.String[]) (http://ActivityThread.java:6494)
09-19 10:04:38.402 I/zygote  ( 6662):   at java.lang.Object java.lang.reflect.Method.invoke(java.lang.Object, java.lang.Object[]) (http://Method.java:-2)
09-19 10:04:38.402 I/zygote  ( 6662):   at void http://com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run() (http://RuntimeInit.java:438)
09-19 10:04:38.402 I/zygote  ( 6662):   at void http://com.android.internal.os.ZygoteInit.main(java.lang.String[]) (ZygoteInit.java:807)
09-19 10:04:38.402 I/zygote  ( 6662): Caused by: java.lang.ClassNotFoundException: Didn't find class "android.view.View$OnUnhandledKeyEventListener" on path: DexPathList[[zip file "/data/app/SampleGraphApp.SampleGraphApp-8lOi1O7QwueWv4f116H2hA==/base.apk"],nativeLibraryDirectories=[/data/app/SampleGraphApp.SampleGraphApp-8lOi1O7QwueWv4f116H2hA==/lib/x86, /data/app/SampleGraphApp.SampleGraphApp-8lOi1O7QwueWv4f116H2hA==/base.apk!/lib/x86, /system/lib, /vendor/lib]]
09-19 10:04:38.402 I/zygote  ( 6662):   at java.lang.Class dalvik.system.BaseDexClassLoader.findClass(java.lang.String) (BaseDexClassLoader.java:125)
09-19 10:04:38.402 I/zygote  ( 6662):   at java.lang.Class java.lang.ClassLoader.loadClass(java.lang.String, boolean) (ClassLoader.java:379)
09-19 10:04:38.402 I/zygote  ( 6662):   at java.lang.Class java.lang.ClassLoader.loadClass(java.lang.String) (ClassLoader.java:312)

@michael-hawker
Copy link
Collaborator Author

@jeromelaban I'm assuming we'll have to update the uno-ui reference here to get the bug fixes needed for the TokenizingTextBox? After those go in to Uno, we should be all set here. Then once the NuGets get updated with the changes from this PR, the PeoplePicker in Uno.Graph-Controls should be all set to go.

@jeromelaban
Copy link
Member

@michael-hawker Yes it'll be all fixes in Uno, just a nuget update to fix all of it :)

XiaotianNetlift and others added 7 commits September 30, 2019 18:05
…nown-type-in-clr-namespace

fixed xamlns `clr-namespace: ...` not working on uwp
```
error : C:\Program Files\dotnet\sdk\3.0.100\Sdks\MSBuild.Sdk.Extras\Sdk not found. Check that a recent enough .NET Core SDK is installed and/or increase the version specified in global.json.
```
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2019

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.