Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Cleanup hit test coercion #17351

Closed
wants to merge 1 commit into from
Closed

refactor: Cleanup hit test coercion #17351

wants to merge 1 commit into from

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia labels Jun 29, 2024
@Youssef1313 Youssef1313 force-pushed the cleanup-hittest-coercion branch from a9ededf to 6596fc1 Compare June 29, 2024 05:31
@Youssef1313 Youssef1313 marked this pull request as draft June 29, 2024 05:33
@Youssef1313 Youssef1313 force-pushed the cleanup-hittest-coercion branch from 6596fc1 to 4051571 Compare June 29, 2024 05:41
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@Youssef1313 Youssef1313 force-pushed the cleanup-hittest-coercion branch from 4051571 to f87aef1 Compare June 29, 2024 06:22
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@Youssef1313 Youssef1313 force-pushed the cleanup-hittest-coercion branch 3 times, most recently from ce42008 to b3a4e71 Compare June 29, 2024 09:26
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@Youssef1313 Youssef1313 force-pushed the cleanup-hittest-coercion branch 2 times, most recently from dd5cdac to d0f666d Compare June 29, 2024 12:51
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@Youssef1313 Youssef1313 force-pushed the cleanup-hittest-coercion branch from d0f666d to f0b9779 Compare July 2, 2024 03:53
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17351/index.html

@Youssef1313 Youssef1313 force-pushed the cleanup-hittest-coercion branch from f0b9779 to 5cc2c29 Compare July 2, 2024 04:38
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@Youssef1313 Youssef1313 force-pushed the cleanup-hittest-coercion branch from 5cc2c29 to b190398 Compare July 4, 2024 16:15
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@Youssef1313 Youssef1313 marked this pull request as ready for review July 4, 2024 18:39
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

@Youssef1313 Youssef1313 force-pushed the cleanup-hittest-coercion branch from 504670f to 32285d7 Compare July 5, 2024 09:52
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17351/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17351/index.html

carldebilly
carldebilly approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@carldebilly carldebilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Youssef1313 Youssef1313 requested a review from dr1rrb July 5, 2024 18:58
@Youssef1313 Youssef1313 mentioned this pull request Jul 22, 2024
Merged
6 tasks
@jeromelaban
Copy link
Member

@Darsh0307 could you quickly test the staging site #17351 (comment)? This is about testing pointers. Try focusing on the manual tests and the button tests.

@Youssef1313
Copy link
Member Author

@jeromelaban @Darsh0307 Not yet please. Things may change for Wasm after David's PR for managed pointers

@jeromelaban jeromelaban marked this pull request as draft July 25, 2024 16:03
@Youssef1313
Copy link
Member Author

Replaced with #17961

@Youssef1313 Youssef1313 deleted the cleanup-hittest-coercion branch August 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carldebilly carldebilly carldebilly approved these changes

@dr1rrb dr1rrb Awaiting requested review from dr1rrb

Assignees
No one assigned
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Youssef1313 @unodevops @jeromelaban @carldebilly