Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration for Astro #11

Closed
wants to merge 0 commits into from
Closed

Add integration for Astro #11

wants to merge 0 commits into from

Conversation

hckhanh
Copy link
Contributor

@hckhanh hckhanh commented Oct 31, 2024

For #9, I want to make a PR to define an integration for Astro

@hckhanh
Copy link
Contributor Author

hckhanh commented Oct 31, 2024

@CahidArda can you give me the feedback?

platforms/astro.ts Outdated Show resolved Hide resolved
@CahidArda
Copy link
Collaborator

CahidArda commented Oct 31, 2024

We want to have example projects with every platforms. We willl write one for Astro too. Would you like to add it too? @hckhanh

A simple endpoint is sufficient like in cloudlfare.

@hckhanh
Copy link
Contributor Author

hckhanh commented Oct 31, 2024

We want to have example projects with every platforms. We willl write one for Astro too. Would you like to add it too? @hckhanh

A simple endpoint is sufficient like in cloudlfare.

Sure @CahidArda, I will put an astro example to the code base.

@hckhanh
Copy link
Contributor Author

hckhanh commented Oct 31, 2024

@CahidArda Can you check again?

platforms/astro.ts Outdated Show resolved Hide resolved
@CahidArda
Copy link
Collaborator

Hi @hckhanh,

My colleague is checking the PR, I will take a look too. Can you allow changes to your pull request by maintainers?

@hckhanh
Copy link
Contributor Author

hckhanh commented Oct 31, 2024

Screenshot 2024-10-31 at 19 37 13

Hi @hckhanh,

My colleague is checking the PR, I will take a look too. Can you allow changes to your pull request by maintainers?

@CahidArda
Copy link
Collaborator

we have nearly finished the astro method, we just couldn't deploy it on Vercel correctly because the app couldn't access th e QSTASH_TOKEN.

We will address this issue, update the deploy button in the README and merge the PR.

@fahreddinozcan
Copy link
Collaborator

@hckhanh closed this by mistake. Working on the fix

@fahreddinozcan fahreddinozcan mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants