-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spat wall time process #2366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishkaMN
requested changes
Apr 19, 2024
carma_wm/src/WMListener.cpp
Outdated
|
||
RCLCPP_INFO_STREAM(node_logging->get_logger(), "Loaded config speed limit: " << config_speed_limit_param.as_double()); | ||
RCLCPP_INFO_STREAM(node_logging->get_logger(), "Loaded vehicle participant type: " << participant_param.as_string()); | ||
RCLCPP_INFO_STREAM(node_logging->get_logger(), "Is using simulation time? : " << use_sim_time_param.as_bool()); | ||
RCLCPP_INFO_STREAM(node_logging->get_logger(), "Is SPaT using system time? : " << is_spat_wall_time_param.as_bool()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets rename to wall time
MishkaMN
previously approved these changes
Apr 19, 2024
MishkaMN
approved these changes
Apr 19, 2024
Quality Gate passedIssues Measures |
@adev4a Feel free to merge if the changes are tested well and you think it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR adds logic to the carma_wm to be able to process SPaT information which is based on a wall clock when running platform along with carla in simulation.
Required for VOICES where the setup doesn't involve a simulation manager like mosaic and doesn't have the traffic controller time synced with the rest of the simulation.
A offset is calculated between wall time and sim time and the spat phase timings are updated to account for this difference while processing.
Description
Related GitHub Issue
Related Jira Key
https://usdot-carma.atlassian.net/browse/VOI-384
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: