Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spat wall time process #2366

Merged
merged 4 commits into from
May 9, 2024
Merged

add spat wall time process #2366

merged 4 commits into from
May 9, 2024

Conversation

adev4a
Copy link
Contributor

@adev4a adev4a commented Apr 19, 2024

PR Details

This PR adds logic to the carma_wm to be able to process SPaT information which is based on a wall clock when running platform along with carla in simulation.
Required for VOICES where the setup doesn't involve a simulation manager like mosaic and doesn't have the traffic controller time synced with the rest of the simulation.
A offset is calculated between wall time and sim time and the spat phase timings are updated to account for this difference while processing.

Description

Related GitHub Issue

Related Jira Key

https://usdot-carma.atlassian.net/browse/VOI-384

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adev4a adev4a requested a review from MishkaMN April 19, 2024 13:36
@MishkaMN MishkaMN added the enhancement New feature or request label Apr 19, 2024

RCLCPP_INFO_STREAM(node_logging->get_logger(), "Loaded config speed limit: " << config_speed_limit_param.as_double());
RCLCPP_INFO_STREAM(node_logging->get_logger(), "Loaded vehicle participant type: " << participant_param.as_string());
RCLCPP_INFO_STREAM(node_logging->get_logger(), "Is using simulation time? : " << use_sim_time_param.as_bool());
RCLCPP_INFO_STREAM(node_logging->get_logger(), "Is SPaT using system time? : " << is_spat_wall_time_param.as_bool());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rename to wall time

@adev4a adev4a self-assigned this Apr 19, 2024
MishkaMN
MishkaMN previously approved these changes Apr 19, 2024
Copy link

sonarcloud bot commented Apr 19, 2024

@MishkaMN
Copy link
Contributor

MishkaMN commented May 6, 2024

@adev4a Feel free to merge if the changes are tested well and you think it's ready

@adev4a adev4a merged commit 83c79f8 into develop May 9, 2024
3 checks passed
@adev4a adev4a deleted the voi-384-fix-spat-processing branch May 9, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants