Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all instances of georeference #2404

Merged
merged 10 commits into from
Jun 17, 2024
Merged

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Jun 11, 2024

PR Details

Description

This PR supports #2403
It fixes all instances of georeference processing callbacks as they might run into same issue.
I separated the 2 PRs just to make it digestable

Related GitHub Issue

#2402

Related Jira Key

https://usdot-carma.atlassian.net/browse/CAR-6059

Motivation and Context

Seen it simulation as well as live vehicle.
Distributed Testing (VOICES) relies on vehicle's valid BSM, so encountered this issue.

How Has This Been Tested?

Tested on Black Pacifica and I didn't see any BSM errors for 5+ runs where I was seeing almost every run.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN requested a review from JonSmet June 11, 2024 17:18
@MishkaMN MishkaMN self-assigned this Jun 11, 2024
@MishkaMN MishkaMN added the anomaly Something isn't working label Jun 11, 2024
@MishkaMN MishkaMN changed the base branch from car-6059-bsm-generator-failure to develop June 11, 2024 17:37
@MishkaMN MishkaMN requested a review from JonSmet June 13, 2024 15:14
@MishkaMN
Copy link
Contributor Author

Fixed all the failing packages, and currently only the cpplint in motion_computation is failing which is being handled in other PR. @JonSmet

@MishkaMN
Copy link
Contributor Author

1: [INFO] [1718392630.629372906] [carma_node]: Destroying
3: /opt/carma/src/carma-platform/motion_computation/src/motion_computation_worker.cpp:152:  Lines should be <= 100 characters long  [whitespace/line_length] [2]
3: /opt/carma/src/carma-platform/motion_computation/src/motion_computation_worker.cpp:157:  Lines should be <= 100 characters long  [whitespace/line_length] [2]
3: Category 'whitespace/line_length' errors found: 2
3: Total errors found: 2

This was the error this time which I fixed

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
48.65% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@JonSmet JonSmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with unit test coverage below 80% since we are resolving a potential race condition on a code block that is duplicated across our codebase. Unit tests for georeference operations could be addressed as part of future testing improvements.

@MishkaMN MishkaMN merged commit d0aac33 into develop Jun 17, 2024
3 of 4 checks passed
@MishkaMN MishkaMN deleted the car-6059-georeference-setting branch June 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants