Fix cpplint test in motion_computation to support CI/CD #2405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Fixing motion_computation cpplint errors introduced in here:
#2399
with the failing github action:
https://github.com/usdot-fhwa-stol/carma-platform/actions/runs/9449278789/job/26037602316?pr=2397#step:13:23837
My environment was never configured for clang format and only used to delete whitespaces. I improved it by:
sudo apt install clang
sudo pip install cpplint
For a lot of the things to take effect and add vertical line indicating the 100 line limit, which one can make false
The cpplint in the CICD is still complaining about the order of the headers. After trying multiple orders, I found an order in autoware.auto that does the job. Despite visually it is correct, not sure why cpplint is still complaining (which
carma_cooperative_perception
also seems to have encountered). Therefore, turning off the check for include orders for now as we haven't established strict convention with it anyways.Related GitHub Issue
NA
Related Jira Key
NA
Motivation and Context
NA
How Has This Been Tested?
CICD passes
Types of changes
Checklist: