Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC 130 Swap out CircleCI Badge for GH Actions #2414

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

john-chrosniak
Copy link
Contributor

@john-chrosniak john-chrosniak commented Jul 8, 2024

PR Details

Description

This PR replaces the outdated CircleCI build badge with the recently added GitHub actions workflow.

Related Jira Key

ARC-130

Motivation and Context

The carma-platform repository’s CI badges currently displayed in its README are outdated. These should be removed and potentially updated with CI badges for the currently-used GitHub Actions workflows.

How Has This Been Tested?

CircleCI badge is now removed from the README and the GitHub actions badge shows the correct build.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@john-chrosniak john-chrosniak self-assigned this Jul 8, 2024
@JonSmet
Copy link
Contributor

JonSmet commented Jul 9, 2024

Thanks for making these updates! I realized I was missing some information in the Jira story, and will add those notes here:

  • We can also remove each 'DockerHub' badge, since we have removed our automated DockerHub processes in favor of GitHub Actions workflows.
  • Let's add separate tables for CI/CD process badges for develop and master similar to how badges are displayed on the V2X Hub repository's README

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@john-chrosniak john-chrosniak added the enhancement New feature or request label Jul 9, 2024
Copy link

sonarcloud bot commented Jul 9, 2024

README.md Outdated Show resolved Hide resolved
@john-chrosniak john-chrosniak merged commit 651b1c6 into develop Jul 9, 2024
2 of 3 checks passed
@john-chrosniak john-chrosniak deleted the arc-130-gh-actions-ci-readme branch July 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants