Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct volume in carma script #2416

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Jul 9, 2024

PR Details

Description

Issue is described in the jira link. But basically when carma config install is called, it created temporary volume of carma-config-tmp to read the .env file.

However, currently it is mistakingly reading it from carma-config volume, instead of carma-config-tmp, which doesnt exist yet (or if existed, it would end up downloading previously set carma-config and not the one specified in install command). This PR fixes it with correct volume.

It was not caught before because I kept resetting or installing same images to verify. If different image was tested, I had tested 4.5.0 which doesnt use .env file.

Related GitHub Issue

NA

Related Jira Key

https://usdot-carma.atlassian.net/browse/ARC-141

Motivation and Context

Fix for bug introduced in #2409

How Has This Been Tested?

black pacifica and fusion vehicles

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN requested a review from adev4a July 9, 2024 19:03
@MishkaMN MishkaMN self-assigned this Jul 9, 2024
@MishkaMN MishkaMN added the anomaly Something isn't working label Jul 9, 2024
Copy link

sonarcloud bot commented Jul 9, 2024

@MishkaMN MishkaMN merged commit 78e2f7e into develop Jul 9, 2024
4 checks passed
@MishkaMN MishkaMN deleted the arc-141-fix-carma-script branch July 9, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants