Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc 258 more humble #2475

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Arc 258 more humble #2475

merged 10 commits into from
Dec 3, 2024

Conversation

john-chrosniak
Copy link
Contributor

@john-chrosniak john-chrosniak commented Dec 2, 2024

PR Details

Description

This PR migrates the following packages to ROS2 Humble:

  1. arbitrator
  2. carma_cloud_client
  3. carma_cooperative_perception
  4. carma_wm_ctrl
  5. frame_transformer
  6. pure_pursuit_wrapper
  7. stop_and_wait_plugin

Related GitHub Issue

NA

Related Jira Key

ARC-258

Motivation and Context

Needed for ROS2 Humble migration.

How Has This Been Tested?

Confirmed that the above packages can build using the usdotfhwastoldev/autoware.ai:develop-humble base image.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@john-chrosniak john-chrosniak self-assigned this Dec 2, 2024
@john-chrosniak john-chrosniak added the enhancement New feature or request label Dec 2, 2024
# file COPYING-CMAKE-SCRIPTS or https://cmake.org/licensing for details.

#[=======================================================================[.rst:
FindPROJ
Copy link
Contributor

@MishkaMN MishkaMN Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this since we added the FindPROJ in cmake? It looks like it built without it anyways. So we should delete the cmake folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it looks like FindPROJ.cmake is not actually needed so I removed it. The rest of the cmake folder is still in use though

Copy link

sonarcloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.8% Duplication on New Code (required ≤ 3%)
30.43% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@john-chrosniak john-chrosniak merged commit a5c5f6f into develop-humble Dec 3, 2024
3 of 5 checks passed
@john-chrosniak john-chrosniak deleted the arc-258-more-humble branch December 3, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants