Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc 257 humbler #2476

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Arc 257 humbler #2476

merged 9 commits into from
Dec 3, 2024

Conversation

john-chrosniak
Copy link
Contributor

@john-chrosniak john-chrosniak commented Dec 3, 2024

PR Details

Description

This PR migrates the following packages to ROS 2 Humble:

  1. localization_manager
  2. motion_computation
  3. platooning_strategic_ihp (previously platoon_strategic_ihp)
  4. points_map_filter
  5. route
  6. route_following_plugin

Related GitHub Issue

NA

Related Jira Key

ARC-257

Motivation and Context

Needed as part of ROS 2 Humble migration.

How Has This Been Tested?

Confirmed the above packages built in the autoware.ai:develop-humble base image

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@john-chrosniak john-chrosniak changed the base branch from develop to develop-humble December 3, 2024 17:00
@john-chrosniak john-chrosniak self-assigned this Dec 3, 2024
@john-chrosniak john-chrosniak added the enhancement New feature or request label Dec 3, 2024
@@ -46,7 +46,7 @@ sonar.modules= bsm_generator, \
carma_wm, \
carma_wm_ctrl, \
roadway_objects, \
platooning_strategic_IHP, \
platoon_strategic_IHP, \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: would it be okay to rename the package and its files to platooning_strategic_ihp
because other tactical and control plugins all follow that naming convention instead of platoon_...

Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)
10.51% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@MishkaMN
Copy link
Contributor

MishkaMN commented Dec 3, 2024

awesome. even docker is building now

@MishkaMN MishkaMN merged commit c251054 into develop-humble Dec 3, 2024
4 of 5 checks passed
@MishkaMN MishkaMN deleted the arc-257-humbler branch December 3, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants