Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensor_data_sharing_service: Update angular and angular covariance, object size fields to optional #428

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

dan-du-car
Copy link
Collaborator

@dan-du-car dan-du-car commented Aug 29, 2024

PR Details

Description

sensor_data_sharing_service cannot parse sensor detected object as it requires angular covariance and object size fields. Must Sensor does not send this information, thus it is unavailable in the sensor detected object.

To allow sensor_data_sharing_service to successfully parse this detected object information, these fields are updated to optional.

Related GitHub Issue

NA

Related Jira Key

https://usdot-carma.atlassian.net/browse/FCP-30

Motivation and Context

NA

How Has This Been Tested?

NA

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dan-du-car dan-du-car changed the title sensor_data_sharing_service: sensor_data_sharing_service: Update angular and angular covariance, object size fields to optional Aug 29, 2024
@dan-du-car dan-du-car marked this pull request as draft August 29, 2024 14:26
@dan-du-car dan-du-car marked this pull request as ready for review August 29, 2024 16:23
Copy link

sonarcloud bot commented Aug 29, 2024

@dan-du-car dan-du-car merged commit 8e9ed56 into develop Aug 29, 2024
2 checks passed
@dan-du-car dan-du-car deleted the change_required_fields branch August 29, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants