Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ROS1 code from carma-utils #234

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Aug 28, 2024

PR Details

Description

This PR removes unused ROS1 code as most of the code is migrated to ROS2 foxy.

Kept:
carma_utils is used by carma_record
driver_shutdown is needed for ROS1 driver launch files

Removed:
cav_driver_utils is used by ros1 drivers, but all of them are deprecated except the ssc driver. Therefore it was also moved to ssc wrapper repo along with socketcan_bridge
socketcan_bridge and socketcan_interface is used by pacifica's dbw controller, so factored into that repo here.
wgs84_utils_ros1 is removed because ROS2 exists.
bsm_helper is ROS1 and ROS2 of which ROS1 can be removed.
uncertainty_tools is ROS1/ROS2 of which ROS1 can be removed. NOTE: novatel_gps_driver depends on this as ROS1. However, the repo is no longer used and should probably be archived.
sigpack: NOTE: it is dependency for carma-vehicle-model-framework, but that repo has not been updated for 3 years, is not used anywhere yet, and no plans to develop for it in the future. We can add it back if needed. Tracking the issue on: usdot-fhwa-stol/carma-platform#2433
trajectory_utils. trajectory_utils_ros2 should be renamed to just trajectory_utils in a different PR.

Related GitHub Issue

usdot-fhwa-stol/carma-platform#2079

Related Jira Key

ARC-146

Motivation and Context

Migration to Foxy

How Has This Been Tested?

Built carma-platform on local VM

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN changed the title first round Remove unused ROS1 code from carma-utils Aug 28, 2024
@MishkaMN
Copy link
Contributor Author

MishkaMN commented Aug 29, 2024

TODO from offline discussion with @adev4a and @JonSmet :

Move socketcan_bridge and socketcan_interface is used by pacifica's dbw controller
cav_driver_utils is used by ros1 drivers to their driver repos.

Copy link
Contributor

@adev4a adev4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we should update the PR description to include wgs84_utils_ros1 as being another package that is being removed. Also, the trajectory_utils dependency in carma-platform inlanecruising should be removed before this change set is committed.
Additionally uncertainty_tools should be removed from sonar-scanner.properties.
Holding off on approving till these change are made

@MishkaMN
Copy link
Contributor Author

MishkaMN commented Sep 9, 2024

I updated the descriptions with those that are being factored into ssc wrapper and those that i missed in removed category.

@MishkaMN MishkaMN changed the title Remove unused ROS1 code from carma-utils Fix Circle CI & Remove unused ROS1 code from carma-utils Sep 9, 2024
@MishkaMN MishkaMN requested a review from adev4a September 9, 2024 17:57
@MishkaMN MishkaMN self-assigned this Sep 9, 2024
@MishkaMN MishkaMN changed the title Fix Circle CI & Remove unused ROS1 code from carma-utils Remove unused ROS1 code from carma-utils Sep 10, 2024
@MishkaMN MishkaMN requested a review from adev4a September 10, 2024 14:04
Copy link

sonarcloud bot commented Sep 10, 2024

@MishkaMN MishkaMN merged commit e84506b into develop Sep 11, 2024
3 checks passed
@MishkaMN MishkaMN deleted the arc-146-remove-ros1 branch September 11, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants