Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change language settings and get rid of static files #102

Merged
merged 12 commits into from
Aug 16, 2023

Conversation

michplunkett
Copy link
Contributor

@michplunkett michplunkett commented Aug 15, 2023

Describe your changes

I updated the language settings in .eslintrc to just look for browser and node JS syntax and removed the watching of the css and js folders since those are never being modified by users. The reason the were removed other than that was because they will update since we are always taking the latest files and it is a bit confusing from a user's perspective. We need the files to be there, but we really don't care what is in them as we presume the maintainers of the libraries have checked.

Bonus: The format function now runs when you run the gulp command.

Checklist before requesting a review

  • All features within the repository still work on my local dev environment.
icj-project-rig % gulp dev
`import sass from 'sass'` is deprecated.
Please use `import * as sass from 'sass'` instead.
[00:31:25] Using gulpfile ~/Documents/GitHub/icj-project-rig/gulpfile.js
[00:31:25] Starting 'dev'...
[00:31:25] Starting 'default'...
[00:31:25] Starting 'clean'...
[00:31:25] Finished 'clean' after 3.78 ms
[00:31:25] Starting 'clean'...
[00:31:25] Starting 'styles'...
[00:31:25] Starting 'copy'...
[00:31:25] Starting 'nunjucks'...
[00:31:25] Starting 'bake'...
[00:31:25] Finished 'clean' after 660 μs
[00:31:25] Starting 'lint'...
[00:31:25] Starting 'scripts'...
[00:31:25] Starting 'images'...
[00:31:25] Finished 'nunjucks' after 123 ms
[00:31:25] Finished 'bake' after 125 ms
[00:31:26] Finished 'lint' after 356 ms
[00:31:28] gulp-imagemin: Minified 0 images
[00:31:28] Finished 'styles' after 3.04 s
[00:31:28] Finished 'scripts' after 2.92 s
[00:31:28] Finished 'copy' after 3.04 s
[00:31:28] Finished 'images' after 2.92 s
[00:31:28] Starting 'format'...
[00:31:28] File 'docs/books/the-clown.html' was not formatted with Prettier
[00:31:28] File 'docs/books/the-hearing-trumpet.html' was not formatted with Prettier
[00:31:28] File 'docs/books/the-shipping-news.html' was not formatted with Prettier
[00:31:28] File 'docs/index.html' was not formatted with Prettier
[00:31:28] Finished 'format' after 102 ms
[00:31:28] Finished 'default' after 3.15 s
[00:31:28] Starting 'serve'...
[Browsersync] Access URLs:
 --------------------------------------
       Local: http://localhost:3001
    External: http://192.168.0.116:3001
 --------------------------------------
          UI: http://localhost:3002
 UI External: http://localhost:3002
 --------------------------------------
[Browsersync] Serving files from: docs

Comment on lines +10 to +12
# Static code
/docs/css/
/docs/js/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the files in here are being updated by gulp, there really isn't any need to store them, etc. What matters is the files they are editing.

@michplunkett michplunkett changed the title Change language settings and get rid of storing static files Change language settings and get rid of static files Aug 15, 2023
@@ -4,7 +4,7 @@
"parser": "@babel/eslint-parser",
"env": {
"browser": true,
"es2024": true
"node": true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the most meaningful change.

@michplunkett michplunkett merged commit c3325d8 into main Aug 16, 2023
2 checks passed
@michplunkett michplunkett deleted the change_language_settings branch August 16, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant