-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change language settings and get rid of static files #102
Conversation
# Static code | ||
/docs/css/ | ||
/docs/js/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the files in here are being updated by gulp, there really isn't any need to store them, etc. What matters is the files they are editing.
@@ -4,7 +4,7 @@ | |||
"parser": "@babel/eslint-parser", | |||
"env": { | |||
"browser": true, | |||
"es2024": true | |||
"node": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the most meaningful change.
Describe your changes
I updated the language settings in
.eslintrc
to just look for browser and node JS syntax and removed the watching of thecss
andjs
folders since those are never being modified by users. The reason the were removed other than that was because they will update since we are always taking the latest files and it is a bit confusing from a user's perspective. We need the files to be there, but we really don't care what is in them as we presume the maintainers of the libraries have checked.Bonus: The format function now runs when you run the
gulp
command.Checklist before requesting a review