Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 28 generic s3 #45

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Refactor 28 generic s3 #45

wants to merge 24 commits into from

Conversation

christyjacob4
Copy link
Contributor

No description provided.

Meldiron
Meldiron requested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tiny code-quality improvements.

Let's also try to implement one test using a Generic adapter. It can connect to the same providers as we use, but it would use Generic, instead of a specific adapter.

src/Storage/Device/Linode.php Outdated Show resolved Hide resolved
@eldadfux eldadfux mentioned this pull request Apr 16, 2022
Closed
2 tasks
lohanidamodar
lohanidamodar reviewed May 9, 2022
View reviewed changes
src/Storage/Device/BackBlaze.php Outdated
@@ -2,9 +2,10 @@

namespace Utopia\Storage\Device;

use Utopia\Storage\Device\S3;
use Utopia\Storage\Device\Generic;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a better name for Generic?
Can we use S3 as base instead of creating new Generic?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S3 is also one of Generic child's.
Can be S3Base? or S3Compatible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference in S3 itself and Generic? if there is a difference then yes Generic can S3Base - S3Base sounds more reasonable than S3Compatible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

lohanidamodar
lohanidamodar reviewed May 10, 2022
View reviewed changes
Copy link
Contributor

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better.

@stnguyen90 stnguyen90 mentioned this pull request Jun 7, 2022
Open
2 tasks
@stnguyen90
Copy link
Contributor

@christyjacob4, is this still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimonewman shimonewman shimonewman left review comments

@lohanidamodar lohanidamodar lohanidamodar left review comments

@Meldiron Meldiron Meldiron requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christyjacob4 @stnguyen90 @lohanidamodar @Meldiron @shimonewman