Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 28 generic s3 #45

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Refactor 28 generic s3 #45

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
52dcf11
bla
shimonewman Apr 6, 2022
6092942
S3 adapter refactor
shimonewman Apr 7, 2022
2f25d8a
tidy
shimonewman Apr 7, 2022
196d8af
add generic test
shimonewman Apr 7, 2022
8a22dec
changed blackBlase region
shimonewman Apr 27, 2022
687be2f
changed s3 region
shimonewman May 1, 2022
e769380
changed s3 region
shimonewman May 2, 2022
47b6355
test fix
shimonewman May 2, 2022
f30737c
wasabi
shimonewman May 2, 2022
270c875
wasabi test
shimonewman May 2, 2022
8e74e82
wasabi test
shimonewman May 2, 2022
49c9afe
wasabi test
shimonewman May 2, 2022
ab04452
preceding slash fix
shimonewman May 3, 2022
16a82a4
Wasabi
shimonewman May 3, 2022
d53e4b0
remove leading /
shimonewman May 8, 2022
7dee353
run all test
shimonewman May 8, 2022
3d4fbf6
Update src/Storage/Device/Linode.php
shimonewman May 9, 2022
4f6adbd
Switched generic to s3
shimonewman May 10, 2022
de30808
Merge remote-tracking branch 'origin/refactor-28-genericS3' into refa…
shimonewman May 10, 2022
8b4e607
resolve conflict
shimonewman May 10, 2022
50fec00
resolve conflict
shimonewman May 10, 2022
edfcaec
resolve conflict
shimonewman May 10, 2022
d546db8
backblaze storage adapter renaming
shimonewman May 17, 2022
fd571d2
backblaze storage adapter renaming
shimonewman May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Storage/Device/BackBlaze.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

namespace Utopia\Storage\Device;

use Utopia\Storage\Device\S3;
use Utopia\Storage\Device\Generic;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a better name for Generic?
Can we use S3 as base instead of creating new Generic?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S3 is also one of Generic child's.
Can be S3Base? or S3Compatible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference in S3 itself and Generic? if there is a difference then yes Generic can S3Base - S3Base sounds more reasonable than S3Compatible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


class BackBlaze extends S3

class BackBlaze extends Generic
{
/**
* Regions constants
Expand All @@ -31,8 +32,8 @@ class BackBlaze extends S3
*/
public function __construct(string $root, string $accessKey, string $secretKey, string $bucket, string $region = self::US_WEST_004, string $acl = self::ACL_PRIVATE)
{
parent::__construct($root, $accessKey, $secretKey, $bucket, $region, $acl);
$this->headers['host'] = $bucket . '.' . 's3' . '.' . $region . '.backblazeb2.com';
$hostName = $bucket . '.' . 's3' . '.' . $region . '.backblazeb2.com';
parent::__construct($root, $accessKey, $secretKey, $bucket, $region, $acl, $hostName);
}

/**
Expand Down
9 changes: 5 additions & 4 deletions src/Storage/Device/DOSpaces.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

namespace Utopia\Storage\Device;

use Utopia\Storage\Device\S3;
use Utopia\Storage\Device\Generic;

class DOSpaces extends S3

class DOSpaces extends Generic
{
/**
* Regions constants
Expand All @@ -29,8 +30,8 @@ class DOSpaces extends S3
*/
public function __construct(string $root, string $accessKey, string $secretKey, string $bucket, string $region = self::NYC3, string $acl = self::ACL_PRIVATE)
{
parent::__construct($root, $accessKey, $secretKey, $bucket, $region, $acl);
$this->headers['host'] = $bucket . '.' . $region . '.digitaloceanspaces.com';
$hostName = $bucket . '.' . $region . '.digitaloceanspaces.com';
parent::__construct($root, $accessKey, $secretKey, $bucket, $region, $acl, $hostName);
}

/**
Expand Down
Loading