refactor: replace global focusin listener with focusout check #7858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #7855
This PR simplifies the logic in
vaadin-grid-pro
that was specifically introduced for handling moving focus from the<input>
to thevaadin-date-picker-overlay-content
, see the following PRs in the old repo:Type of change
Note
I have moved one of the tests to the new test suite for grid-pro with custom editors and removed the old integration test. It was using rather complicated setup with
vaadin-dialog
since the workaround was specifically checking for the tag name of the overlay where the focus is moving, and this is no longer the case (we now rely on_shouldRemoveFocus()
instead).