Untrademark json files #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one just removes the word Redis or replaces it with server. It's independent of the name we pick for the project. It's strings visible in documentation, so we want to change this. Thus, ready to review imo. |
madolson
reviewed
Mar 26, 2024
| @@ -32,7 +32,7 @@ | |||
| "type": "string" | |||
| }, | |||
| "since": { | |||
| "description": "the Redis version that added the command (or for module commands, the module version).", | |||
| "description": "the server verion that added the command (or for module commands, the module version).", | |||
There was a problem hiding this comment.
Suggested change
| "description": "the server verion that added the command (or for module commands, the module version).", | |
| "description": "the server version that added the command (or for module commands, the module version).", |
There was a problem hiding this comment.
Yeah I misspelled in the mass replace. 😪
| @@ -118,7 +118,7 @@ | |||
| } | |||
| }, | |||
| "deprecated_since": { | |||
| "description": "the Redis version that deprecated the command (or for module commands, the module version)", | |||
| "description": "the server verion that deprecated the command (or for module commands, the module version)", | |||
There was a problem hiding this comment.
Suggested change
| "description": "the server verion that deprecated the command (or for module commands, the module version)", | |
| "description": "the server version that deprecated the command (or for module commands, the module version)", |
| @@ -135,7 +135,7 @@ | |||
| "items": [ | |||
| { | |||
| "type": "string", | |||
| "description": "The Redis version that the entry applies to." | |||
| "description": "The server verion that the entry applies to." | |||
There was a problem hiding this comment.
Suggested change
| "description": "The server verion that the entry applies to." | |
| "description": "The server version that the entry applies to." |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "LOLWUT": { | |||
| "summary": "Displays computer art and the Redis version", | |||
| "summary": "Displays computer art and the server verion", | |||
There was a problem hiding this comment.
Suggested change
| "summary": "Displays computer art and the server verion", | |
| "summary": "Displays computer art and the server version", |
| @@ -11,7 +11,7 @@ | |||
| ], | |||
| "reply_schema": { | |||
| "type": "string", | |||
| "description": "String containing the generative computer art, and a text with the Redis version." | |||
| "description": "String containing the generative computer art, and a text with the server verion." | |||
There was a problem hiding this comment.
Suggested change
| "description": "String containing the generative computer art, and a text with the server verion." | |
| "description": "String containing the generative computer art, and a text with the server version." |
|
I accidentally created this branch on placeholderkv repo instead of on my own dev fork. I'll need to reopen it as another PR. |
Merged
|
So currently I can't even delete the branch on this repo, i.e. https://github.com/placeholderkv/placeholderkv/tree/untrademark-json-files Btw I think we clean up old branches, remains from many years ago. |
madolson
pushed a commit
that referenced
this pull request
Mar 26, 2024
Replaces #26 Name agnostic. Now without spelling errors, ready to merge if you ask me.
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
Replaces valkey-io#26 Name agnostic. Now without spelling errors, ready to merge if you ask me.
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
…valkey-io#26) (valkey-io#45) Changing some references from Redis to placeholderkv. Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #25
Covers
src/commands/*.jsonandsrc/commands/README.md